From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbbIPECT (ORCPT ); Wed, 16 Sep 2015 00:02:19 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:35460 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbbIPECS (ORCPT ); Wed, 16 Sep 2015 00:02:18 -0400 From: Yang Yingliang To: , CC: Yang Yingliang , Jiang Liu , Thomas Gleixner , "Marc Zyngier" , Mark Rutland , "Will Deacon" , Russell King - ARM Linux , Hanjun Guo Subject: [RFC PATCH v3 0/3] arm/arm64: fix a migrating irq bug when hotplug cpu Date: Wed, 16 Sep 2015 11:58:24 +0800 Message-ID: <1442375907-11496-1-git-send-email-yangyingliang@huawei.com> X-Mailer: git-send-email 1.9.5.msysgit.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.19.219] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ---- Changes in v3: - introduce config GENERIC_IRQ_MIGRATION for compiling migration.c - rename migrate_irqs in arch/ia64/kernel/irq.c to avoid compiling error Changes in v2: - use the exiting helper to set IRQD_MOVE_PCNTXT flag - use for_each_active_irq() instead of for_each_irq_desc() - add some warn messages when affinity is null or do set affinity failed ---- Hi All, There is a bug: When cpu is disabled, all irqs will be migratged to another cpu. In some cases, a new affinity is different, it needed to be coppied to irq's affinity. But if the type of irq is LPI, it's affinity will not be coppied because of irq_set_affinity's return value. As Marc and Will suggested, I refactor the arm/arm64 migrating interrupts code and fix the migrating irq bug while cpu is offline. I'm trying let the core code do the migrating interrupts matter. kernel/irq/migration.c depends on CONFIG_GENERIC_PENDING_IRQ, so I introduce config GENERIC_IRQ_MIGRATION for compiling migration.c. On ia64, there is a migrate_irqs() in arch/ia64/kernel/irq.c, rename it to avoid compiling error. With the above preparation, move the migrating interrupts code into kernel/irq/migration.c and fix the bug by using irq_do_set_affinity(). Cc: Jiang Liu Cc: Thomas Gleixner Cc: Marc Zyngier Cc: Mark Rutland Cc: Will Deacon Cc: Russell King - ARM Linux Cc: Hanjun Guo Yang Yingliang (3): genirq: introduce CONFIG_GENERIC_IRQ_MIGRATION ia64: rename migrate_irqs() to avoid compiling error arm/arm64: fix a migrating irq bug when hotplug cpu arch/arc/Kconfig | 1 + arch/arm/Kconfig | 1 + arch/arm/include/asm/irq.h | 1 - arch/arm/kernel/irq.c | 62 ---------------------------------------- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/irq.h | 1 - arch/arm64/kernel/irq.c | 62 ---------------------------------------- arch/hexagon/Kconfig | 1 + arch/ia64/Kconfig | 1 + arch/ia64/kernel/irq.c | 4 +-- arch/tile/Kconfig | 1 + arch/x86/Kconfig | 1 + include/linux/irq.h | 4 +++ kernel/irq/Kconfig | 4 +++ kernel/irq/Makefile | 2 +- kernel/irq/migration.c | 68 ++++++++++++++++++++++++++++++++++++++++++++ 16 files changed, 86 insertions(+), 129 deletions(-) -- 2.5.0