From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752261AbbIPGPI (ORCPT ); Wed, 16 Sep 2015 02:15:08 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:9892 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbbIPGPF (ORCPT ); Wed, 16 Sep 2015 02:15:05 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 15 Sep 2015 23:09:49 -0700 From: Vince Hsu To: , , , , , , CC: , , , , Vince Hsu Subject: [PATCH] clk: tegra: dfll: add missing rcu_read_unlock() for error path Date: Wed, 16 Sep 2015 14:14:54 +0800 Message-ID: <1442384094-22144-1-git-send-email-vinceh@nvidia.com> X-Mailer: git-send-email 2.1.4 X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vince Hsu The commit e770940218028c6a5927fda45f2ca9db5d9b35e0 ("clk: tegra: dfll: Properly protect OPP list") added the rcu_read_{lock,unlock} but missed one in the error path. So add the missing one. Signed-off-by: Vince Hsu --- Hi, I noticed the missed unlock because we had a similar fix as the commit e77094021 in ChromeOS[1]. [1] https://chromium-review.googlesource.com/#/c/223661/ drivers/clk/tegra/clk-dfll.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-dfll.c b/drivers/clk/tegra/clk-dfll.c index 4adff56dd0ef..c4e3a52e225b 100644 --- a/drivers/clk/tegra/clk-dfll.c +++ b/drivers/clk/tegra/clk-dfll.c @@ -685,8 +685,10 @@ static int find_lut_index_for_rate(struct tegra_dfll *td, unsigned long rate) rcu_read_lock(); opp = dev_pm_opp_find_freq_ceil(td->soc->dev, &rate); - if (IS_ERR(opp)) + if (IS_ERR(opp)) { + rcu_read_unlock(); return PTR_ERR(opp); + } uv = dev_pm_opp_get_voltage(opp); rcu_read_unlock(); -- 2.1.4