From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753390AbbIPJIr (ORCPT ); Wed, 16 Sep 2015 05:08:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54409 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752547AbbIPJIq (ORCPT ); Wed, 16 Sep 2015 05:08:46 -0400 From: Maurizio Lombardi To: tj@kernel.org Cc: joe@perches.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org Subject: [RFC PATCH 0/3] fix *pbl format support Date: Wed, 16 Sep 2015 11:08:40 +0200 Message-Id: <1442394523-19176-1-git-send-email-mlombard@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, I tried to fix the "*pb[l]" format issue while taking care of the problems discussed in this thread: https://lkml.org/lkml/2015/9/9/153 I would like to know whether this approach is more acceptable to you: PATCH 1 modifies the code so that the printf_spec struct is not passed by value anymore, instead a const pointer is used and the structure is copied to a local variable only when necessary. PATCH 2 modifies the bitmap_*_string() functions so they'll append "..." to the output string whenever the buffer is not sufficiently large. example of output: *pb: cccccccc,... *pbl: 1-2,5-7,... PATCH 3 increases the size of printf_spec.field_width (from s16 to s32). Maurizio Lombardi (3): lib/vsprintf.c: Do not pass printf_spec by value on stack. lib/vsprintf.c: append "..." if the *pb[l] output has been truncated. lib/vsprintf.c: increase the size of the field_width variable lib/vsprintf.c | 275 +++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 167 insertions(+), 108 deletions(-) -- Maurizio Lombardi