From: Eric Dumazet <eric.dumazet@gmail.com>
To: Matteo Croce <matteo@openwrt.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] add stealth mode
Date: Wed, 16 Sep 2015 04:11:22 -0700 [thread overview]
Message-ID: <1442401882.4116.52.camel@edumazet-glaptop2.roam.corp.google.com> (raw)
In-Reply-To: <1442397259-28894-1-git-send-email-matteo@openwrt.org>
On Wed, 2015-09-16 at 11:54 +0200, Matteo Croce wrote:
> diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
> index 93898e0..fe62ae0 100644
> --- a/net/ipv4/tcp_ipv4.c
> +++ b/net/ipv4/tcp_ipv4.c
> @@ -77,6 +77,7 @@
> #include <net/busy_poll.h>
>
> #include <linux/inet.h>
> +#include <linux/inetdevice.h>
> #include <linux/ipv6.h>
> #include <linux/stddef.h>
> #include <linux/proc_fs.h>
> @@ -1652,7 +1653,7 @@ csum_error:
> TCP_INC_STATS_BH(net, TCP_MIB_CSUMERRORS);
> bad_packet:
> TCP_INC_STATS_BH(net, TCP_MIB_INERRS);
> - } else {
> + } else if (!IN_DEV_STEALTH(skb->dev->ip_ptr)) {
> tcp_v4_send_reset(NULL, skb);
> }
It is illegal to deref skb->dev->ip_ptr without proper accessor /
annotations.
Check
struct in_device *in_dev = __in_dev_get_rcu(skb->dev);
(Same remarks in other places of your patch)
next prev parent reply other threads:[~2015-09-16 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 8:47 [PATCH] [PATCH v3] " Matteo Croce
2015-09-15 19:00 ` David Miller
2015-09-16 9:54 ` [PATCH v4] " Matteo Croce
2015-09-16 10:26 ` Daniel Borkmann
2015-09-16 10:45 ` Matteo Croce
2015-09-16 11:11 ` Daniel Borkmann
2015-09-16 11:06 ` Florian Westphal
2015-09-23 16:36 ` Matteo Croce
2015-09-23 17:29 ` Eric Dumazet
2015-09-23 18:16 ` David Miller
2015-09-23 18:15 ` David Miller
2015-09-16 11:11 ` Eric Dumazet [this message]
2015-09-23 16:32 ` Matteo Croce
2015-09-23 18:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442401882.4116.52.camel@edumazet-glaptop2.roam.corp.google.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matteo@openwrt.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®