From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbbIPUm7 (ORCPT ); Wed, 16 Sep 2015 16:42:59 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36001 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220AbbIPUm6 (ORCPT ); Wed, 16 Sep 2015 16:42:58 -0400 From: Douglas Anderson To: airlied@linux.ie Cc: fabio.estevam@freescale.com, ykk@rock-chips.com, Douglas Anderson , rmk+kernel@arm.linux.org.uk, p.zabel@pengutronix.de, andy.yan@rock-chips.com, treding@nvidia.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] CHROMIUM: drm: bridge/dw_hdmi: Eliminate unused cable_plugin Date: Wed, 16 Sep 2015 13:41:38 -0700 Message-Id: <1442436098-26608-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.6.0.rc0.131.gf624c3d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's a member in 'struct dw_hdmi' called cable_plugin. It's never set to anything anywhere so thus is always false. There's a bit of code checking it, but since it's always false this must be dead code. Eliminate it. Note: if someone wants to figure out the intention of the original code and implement whatever feature / fix was needed then we can drop this patch. The 'cable_plugin' member has been unused since the code was first added in (9aaf880 imx-drm: Add mx6 hdmi transmitter support). Signed-off-by: Douglas Anderson --- drivers/gpu/drm/bridge/dw_hdmi.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c index 0083d4e..ba90885 100644 --- a/drivers/gpu/drm/bridge/dw_hdmi.c +++ b/drivers/gpu/drm/bridge/dw_hdmi.c @@ -115,7 +115,6 @@ struct dw_hdmi { int vic; u8 edid[HDMI_EDID_LEN]; - bool cable_plugin; bool phy_enabled; struct drm_display_mode previous_mode; @@ -1203,12 +1202,6 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) hdmi_writeb(hdmi, val, HDMI_FC_INVIDCONF); } -static void hdmi_enable_overflow_interrupts(struct dw_hdmi *hdmi) -{ - hdmi_writeb(hdmi, 0, HDMI_FC_MASK2); - hdmi_writeb(hdmi, 0, HDMI_IH_MUTE_FC_STAT2); -} - static void hdmi_disable_overflow_interrupts(struct dw_hdmi *hdmi) { hdmi_writeb(hdmi, HDMI_IH_MUTE_FC_STAT2_OVERFLOW_MASK, @@ -1285,8 +1278,6 @@ static int dw_hdmi_setup(struct dw_hdmi *hdmi, struct drm_display_mode *mode) hdmi_tx_hdcp_config(hdmi); dw_hdmi_clear_overflow(hdmi); - if (hdmi->cable_plugin && hdmi->sink_is_hdmi) - hdmi_enable_overflow_interrupts(hdmi); return 0; } -- 2.6.0.rc0.131.gf624c3d