From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbbIQKJF (ORCPT ); Thu, 17 Sep 2015 06:09:05 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37446 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbbIQKJE (ORCPT ); Thu, 17 Sep 2015 06:09:04 -0400 From: Peter Senna Tschudin To: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, jolsa@kernel.org, matt.fleming@intel.com, namhyung@kernel.org, milos@redhat.com, kan.liang@intel.com, rostedt@goodmis.org, linux-kernel@vger.kernel.org Cc: Peter Senna Tschudin Subject: [PATCH] tools-perf: Change -1 by false Date: Thu, 17 Sep 2015 12:08:53 +0200 Message-Id: <1442484533-19742-1-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 2.1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Returning a negative value for a boolean function seem to have the undesired effect of returning true. Replace -1 by false in a bool-returning function. The diff of the .s file before and after the change (for x86_64): 3907c3907 < movl $1, %ebx --- > xorl %ebx, %ebx while if -1 is replaced by true, the diff is empty. This issue was found by the following Coccinelle semantic patch: @@ identifier f; constant C; typedef bool; @@ bool f (...){ <+... * return -C; ...+> } Signed-off-by: Peter Senna Tschudin --- tools/perf/util/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c index 49a5c6a..ce465b2 100644 --- a/tools/perf/util/util.c +++ b/tools/perf/util/util.c @@ -639,7 +639,7 @@ bool find_process(const char *name) dir = opendir(procfs__mountpoint()); if (!dir) - return -1; + return false; /* Walk through the directory. */ while (ret && (d = readdir(dir)) != NULL) { -- 2.1.0