mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kapileshwar Singh <kapileshwar.singh@arm.com>
To: linux-kernel@vger.kernel.org
Cc: Kapileshwar Singh <kapileshwar.singh@arm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Javi Merino <javi.merino@arm.com>,
	David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@kernel.org>
Subject: [PATCH] tools lib traceevent: Mask higher bits of str addresses for 32-bit traces
Date: Thu, 17 Sep 2015 12:14:36 +0100	[thread overview]
Message-ID: <1442488476-15366-1-git-send-email-kapileshwar.singh@arm.com> (raw)

When a trace recorded on a 32-bit device is processed with a 64-bit
binary, the higher 32-bits of the address need to be masked.

The lack of this results in the output of the 64-bit pointer
value to the trace as the 32-bit address lookup fails in find_printk.

Before:
burn-1778  [003]   548.600305: bputs:   0xc0046db2s: 2cec5c058d98c

After:
burn-1778  [003]   548.600305: bputs:	0xc0046db2s: RT throttling activated

The problem occurs in PRINT_FEILD when the field is recognized as a pointer
to a string (of the type const char *)

Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Javi Merino <javi.merino@arm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Reported-by: Juri-Lelli <juri.lelli@arm.com>
Signed-off-by: Kapileshwar Singh <kapileshwar.singh@arm.com>
---
 tools/lib/traceevent/event-parse.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 4d885934b919..39163ea4a048 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -3829,6 +3829,17 @@ static void print_str_arg(struct trace_seq *s, void *data, int size,
 		if (!(field->flags & FIELD_IS_ARRAY) &&
 		    field->size == pevent->long_size) {
 			addr = *(unsigned long *)(data + field->offset);
+
+			/* In case the long_size is 4. The higher 32bits
+			 * need to be masked for a successful lookup in
+			 * in the printk table. As the pointers are 32-bit
+			 * long. This could happen if a trace recorded on
+			 * 32-bit platform is processed using a 64-bit
+			 * binary
+			 */
+			if (pevent->long_size == 4)
+				addr = addr & 0xffffffff;
+
 			/* Check if it matches a print format */
 			printk = find_printk(pevent, addr);
 			if (printk)
-- 
1.9.1


             reply	other threads:[~2015-09-17 11:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 11:14 Kapileshwar Singh [this message]
2015-09-17 13:11 ` Steven Rostedt
2015-09-17 14:58   ` Kapileshwar Singh
2015-09-17 15:26     ` Namhyung Kim
2015-09-18 10:55       ` Kapileshwar Singh
2015-09-18 13:45         ` Steven Rostedt
2015-09-18 14:29           ` Kapileshwar Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442488476-15366-1-git-send-email-kapileshwar.singh@arm.com \
    --to=kapileshwar.singh@arm.com \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=javi.merino@arm.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®