From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org
Subject: [PATCH v2 2/4] scsi: cleanup scsi/scsi_ioctl.h
Date: Thu, 17 Sep 2015 15:42:16 +0200 [thread overview]
Message-ID: <1442497338-17019-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1442497338-17019-1-git-send-email-pbonzini@redhat.com>
SCSI_REMOVAL_* goes together with other SCSI command constants in
include/scsi/scsi.h. It is also used outside the implementation
of the ioctls (and it is not part of the user API).
scsi_fctargaddress/Scsi_FCTargAddress has had no in-tree use since
commit ca61f10ab2b8 ("[SCSI] remove broken driver cpqfc", 2005-10-29).
Remove it, just in time for the the tenth anniversary of its demise.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
include/scsi/scsi.h | 6 ++++++
include/scsi/scsi_ioctl.h | 8 --------
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
index e0a3398b1547..5e2bafdbd96f 100644
--- a/include/scsi/scsi.h
+++ b/include/scsi/scsi.h
@@ -279,6 +279,12 @@ static inline int scsi_is_wlun(u64 lun)
#define SCSI_INQ_PQ_NOT_CON 0x01
#define SCSI_INQ_PQ_NOT_CAP 0x03
+/*
+ * PREVENT/ALLOW MEDIUM REMOVAL
+ */
+#define SCSI_REMOVAL_PREVENT 1
+#define SCSI_REMOVAL_ALLOW 0
+
/*
* Here are some scsi specific ioctl commands which are sometimes useful.
diff --git a/include/scsi/scsi_ioctl.h b/include/scsi/scsi_ioctl.h
index 8d19d1d233c3..c81962bef7a0 100644
--- a/include/scsi/scsi_ioctl.h
+++ b/include/scsi/scsi_ioctl.h
@@ -12,9 +12,6 @@
#define SCSI_IOCTL_DOORLOCK 0x5380 /* lock the eject mechanism */
#define SCSI_IOCTL_DOORUNLOCK 0x5381 /* unlock the mechanism */
-#define SCSI_REMOVAL_PREVENT 1
-#define SCSI_REMOVAL_ALLOW 0
-
#ifdef __KERNEL__
struct scsi_device;
@@ -34,11 +31,6 @@ typedef struct scsi_idlun {
__u32 host_unique_id;
} Scsi_Idlun;
-/* Fibre Channel WWN, port_id struct */
-typedef struct scsi_fctargaddress {
- __u32 host_port_id;
- unsigned char host_wwn[8]; // include NULL term.
-} Scsi_FCTargAddress;
int scsi_ioctl_block_when_processing_errors(struct scsi_device *sdev,
int cmd, bool ndelay);
--
2.5.0
next prev parent reply other threads:[~2015-09-17 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 13:42 [PATCH v2 0/4] scsi: cleanup ioctl headers and provide UAPI versions Paolo Bonzini
2015-09-17 13:42 ` [PATCH v2 1/4] scsi: remove old-style type names from sg.h Paolo Bonzini
2015-09-17 15:24 ` Bart Van Assche
2015-09-17 13:42 ` Paolo Bonzini [this message]
2015-09-17 15:27 ` [PATCH v2 2/4] scsi: cleanup scsi/scsi_ioctl.h Bart Van Assche
2015-09-17 13:42 ` [PATCH v2 3/4] scsi: move all obsolete ioctls to scsi/scsi_ioctl.h Paolo Bonzini
2015-09-17 15:26 ` Bart Van Assche
2015-09-17 13:47 ` [PATCH v2 4/4] scsi: provide UAPI version of scsi/sg.h and scsi/scsi_ioctl.h Paolo Bonzini
2015-09-17 15:32 ` Bart Van Assche
2015-09-25 8:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442497338-17019-3-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®