From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752318AbbIQQo5 (ORCPT ); Thu, 17 Sep 2015 12:44:57 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:33930 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752670AbbIQQoz (ORCPT ); Thu, 17 Sep 2015 12:44:55 -0400 From: Sudip Mukherjee To: Lior Dotan , Christopher Harrer , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Sudip Mukherjee Subject: [PATCH 4/4] staging: slicoss: use status in isr Date: Thu, 17 Sep 2015 22:14:35 +0530 Message-Id: <1442508275-5080-4-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1442508275-5080-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1442508275-5080-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If we are not able to setup the LINK UP command then don't increment the interrupt count. Signed-off-by: Sudip Mukherjee --- This is placed at the last as I am not sure if we should be decrement the count. We got the interrupt but we could not service it properly. But in any case this count is not used anywhere. drivers/staging/slicoss/slicoss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 6ff0b83..2025b61 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b/drivers/staging/slicoss/slicoss.c @@ -2110,7 +2110,8 @@ static void slic_interrupt_card_up(u32 isr, struct adapter *adapter, if (isr & ISR_LEVENT) { adapter->linkevent_interrupts++; - slic_link_event_handler(adapter); + if (slic_link_event_handler(adapter)) + adapter->linkevent_interrupts--; } if ((isr & ISR_UPC) || (isr & ISR_UPCERR) || -- 1.9.1