From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752103AbbIQWsY (ORCPT <rfc822;w@1wt.eu>);
	Thu, 17 Sep 2015 18:48:24 -0400
Received: from mga01.intel.com ([192.55.52.88]:52789 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751633AbbIQWsW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 17 Sep 2015 18:48:22 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,549,1437462000"; 
   d="scan'208";a="647141555"
Message-ID: <1442530080.2489.5.camel@spandruv-desk3.jf.intel.com>
Subject: Re: [PATCH 13/17] thermal: int340x: allow compile test
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Eduardo Valentin <edubezval@gmail.com>, Rui Zhang <rui.zhang@intel.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "lan,Tianyu" <tianyu.lan@intel.com>,
        Ilkka Koskinen <ilkka.koskinen@linux.intel.com>
Date: Thu, 17 Sep 2015 15:48:00 -0700
In-Reply-To: <CAMuHMdXd5=qZd17czeYPQMBDaUYyC7JCB+1S49dVPfgm=Xp_iQ@mail.gmail.com>
References: <1441858273-4017-1-git-send-email-edubezval@gmail.com>
	 <1441858273-4017-14-git-send-email-edubezval@gmail.com>
	 <CAMuHMdXd5=qZd17czeYPQMBDaUYyC7JCB+1S49dVPfgm=Xp_iQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 2015-09-10 at 08:31 +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 10, 2015 at 6:11 AM, Eduardo Valentin <edubezval@gmail.com> wrote:
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -317,7 +317,7 @@ config INTEL_QUARK_DTS_THERMAL
> >
> >  config INT340X_THERMAL
> >         tristate "ACPI INT340X thermal drivers"
> > -       depends on X86 && ACPI
> > +       depends on (X86 && ACPI) || COMPILE_TEST
> >         select THERMAL_GOV_USER_SPACE
> >         select ACPI_THERMAL_REL
> >         select ACPI_FAN
> 
> This driver selects INTEL_SOC_DTS_IOSF_CORE, which uses an x86-specific
> header file.
> 
> drivers/thermal/int340x_thermal/int3400_thermal.c: In function
> ‘int3400_thermal_get_uuids’:
> drivers/thermal/int340x_thermal/int3400_thermal.c:120: error:
> dereferencing pointer to incomplete type
> 
> Missing #include <linux/fs.h>
> 
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
> ‘acpi_parse_trt’:
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c:85: error: implicit
> declaration of function ‘acpi_has_method’
> 
> Missing #include <acpi/acpi_bus.h>
> 
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c: In function
> ‘acpi_parse_trt’:
> drivers/thermal/int340x_thermal/acpi_thermal_rel.c:125: error:
> implicit declaration of function ‘acpi_bus_get_device’
> 
> Definition depends on CONFIG_ACPI
> 
Yes. This has dependency on ACPI. We need to also include ACPI modules
to build. For IOSF we need to have stub functions for core calls.

Thanks,
Srinivas

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html