From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752456AbbIRI2A (ORCPT ); Fri, 18 Sep 2015 04:28:00 -0400 Received: from mga14.intel.com ([192.55.52.115]:63326 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbbIRI16 (ORCPT ); Fri, 18 Sep 2015 04:27:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,551,1437462000"; d="scan'208";a="807923027" From: Andy Shevchenko To: Andrew Morton , linux-kernel@vger.kernel.org, Alexander Viro Cc: Andy Shevchenko Subject: [PATCH v1 1/1] fs/proc/array.c: set overflow flag in case of error Date: Fri, 18 Sep 2015 11:27:52 +0300 Message-Id: <1442564872-126468-1-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.5.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For now in task_name() we ignore the return code of string_escape_str() call. This is not good if buffer suddenly becomes not big enough. Do the proper error handling there. Signed-off-by: Andy Shevchenko --- fs/proc/array.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index f60f012..21d2d30 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -91,18 +91,17 @@ static inline void task_name(struct seq_file *m, struct task_struct *p) { char *buf; + size_t size = seq_get_buf(m, &buf); char tcomm[sizeof(p->comm)]; + int ret; get_task_comm(tcomm, p); seq_puts(m, "Name:\t"); - buf = m->buf + m->count; - /* Ignore error for now */ - buf += string_escape_str(tcomm, buf, m->size - m->count, - ESCAPE_SPACE | ESCAPE_SPECIAL, "\n\\"); + ret = string_escape_str(tcomm, buf, size, ESCAPE_SPACE | ESCAPE_SPECIAL, "\n\\"); + seq_commit(m, ret < size ? ret : -1); - m->count = buf - m->buf; seq_putc(m, '\n'); } -- 2.5.1