From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753386AbbIRIv1 (ORCPT ); Fri, 18 Sep 2015 04:51:27 -0400 Received: from mga03.intel.com ([134.134.136.65]:34767 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbbIRIvZ (ORCPT ); Fri, 18 Sep 2015 04:51:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,551,1437462000"; d="scan'208";a="807248379" From: Andy Shevchenko To: Andrew Morton , linux-kernel@vger.kernel.org, Alexander Viro Cc: Andy Shevchenko Subject: [PATCH 1/1] fs/seq_file: use seq_* helpers in seq_hex_dump() Date: Fri, 18 Sep 2015 11:51:21 +0300 Message-Id: <1442566281-139187-1-git-send-email-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.5.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This improves code readability. Signed-off-by: Andy Shevchenko --- fs/seq_file.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/fs/seq_file.c b/fs/seq_file.c index 6f0c3d7..ade4ea2 100644 --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -752,6 +752,8 @@ void seq_hex_dump(struct seq_file *m, const char *prefix_str, int prefix_type, { const u8 *ptr = buf; int i, linelen, remaining = len; + char *buffer; + size_t size; int ret; if (rowsize != 16 && rowsize != 32) @@ -773,15 +775,12 @@ void seq_hex_dump(struct seq_file *m, const char *prefix_str, int prefix_type, break; } + size = seq_get_buf(m, &buffer); ret = hex_dump_to_buffer(ptr + i, linelen, rowsize, groupsize, - m->buf + m->count, m->size - m->count, - ascii); - if (ret >= m->size - m->count) { - seq_set_overflow(m); - } else { - m->count += ret; - seq_putc(m, '\n'); - } + buffer, size, ascii); + seq_commit(m, ret < size ? ret : -1); + + seq_putc(m, '\n'); } } EXPORT_SYMBOL(seq_hex_dump); -- 2.5.1