From: eu@felipetonello.com
To: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Peter Chen <Peter.Chen@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@ti.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
"Felipe F. Tonello" <eu@felipetonello.com>
Subject: [PATCH 1/3] usb: chipidea: udc: _ep_queue and _hw_queue cleanup
Date: Fri, 18 Sep 2015 18:30:19 +0100 [thread overview]
Message-ID: <1442597421-3641-1-git-send-email-eu@felipetonello.com> (raw)
From: "Felipe F. Tonello" <eu@felipetonello.com>
Update comments to reflect current state of functions.
Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
Changes for v2:
- Introduced this patch.
drivers/usb/chipidea/udc.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 764f668..c936c72 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -404,9 +404,9 @@ static inline u8 _usb_addr(struct ci_hw_ep *ep)
}
/**
- * _hardware_queue: configures a request at hardware level
- * @gadget: gadget
+ * _hardware_enqueue: configures a request at hardware level
* @hwep: endpoint
+ * @hwreq: request
*
* This function returns an error code
*/
@@ -750,8 +750,12 @@ static void isr_get_status_complete(struct usb_ep *ep, struct usb_request *req)
/**
* _ep_queue: queues (submits) an I/O request to an endpoint
+ * @ep: endpoint
+ * @req: request
+ * @gfp_flags: GFP flags (not used)
*
* Caller must hold lock
+ * This function returns an error code
*/
static int _ep_queue(struct usb_ep *ep, struct usb_request *req,
gfp_t __maybe_unused gfp_flags)
--
2.1.4
next reply other threads:[~2015-09-18 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 17:30 eu [this message]
2015-09-18 17:30 ` [PATCH 2/3] usb: chipidea: udc: improve error handling on ep_queue eu
2015-10-22 1:41 ` Peter Chen
2015-10-27 9:27 ` Felipe Ferreri Tonello
2015-10-27 9:29 ` Peter Chen
2015-09-18 17:30 ` [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue eu
2015-09-18 17:32 ` Felipe Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442597421-3641-1-git-send-email-eu@felipetonello.com \
--to=eu@felipetonello.com \
--cc=Peter.Chen@freescale.com \
--cc=andrzej.p@samsung.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®