From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org
Cc: linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
mathieu.poirier@linaro.org
Subject: [PATCH] perf record: adding dummy event before mapping
Date: Fri, 18 Sep 2015 14:42:04 -0600 [thread overview]
Message-ID: <1442608924-28139-1-git-send-email-mathieu.poirier@linaro.org> (raw)
The parameters of function 'perf_evsel__open()' in
'record_open()' have been changed to use the evsel's cpus and
threads rather than the evlist since:
commit d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads")
This works fine for as long as all the events have been added to
the evlist before function 'perf_evlist__create_maps()' is called
since the latter will take care of pushing the cpus and threads of
the evlist to each of the evsel in the list.
As function 'auxtrace_record__options()' adds a "dummy:u" event to
the evlist it is important that it runs before
'perf_evlist__create_maps()'.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
---
tools/perf/builtin-record.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 142eeb341b29..630a7a8e3970 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1183,14 +1183,14 @@ int cmd_record(int argc, const char **argv, const char *prefix __maybe_unused)
goto out_symbol_exit;
}
- err = -ENOMEM;
- if (perf_evlist__create_maps(rec->evlist, &rec->opts.target) < 0)
- usage_with_options(record_usage, record_options);
-
err = auxtrace_record__options(rec->itr, rec->evlist, &rec->opts);
if (err)
goto out_symbol_exit;
+ err = -ENOMEM;
+ if (perf_evlist__create_maps(rec->evlist, &rec->opts.target) < 0)
+ usage_with_options(record_usage, record_options);
+
if (record_opts__config(&rec->opts)) {
err = -EINVAL;
goto out_symbol_exit;
--
1.9.1
next reply other threads:[~2015-09-18 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 20:42 Mathieu Poirier [this message]
2015-09-18 20:49 ` Arnaldo Carvalho de Melo
2015-09-18 23:38 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442608924-28139-1-git-send-email-mathieu.poirier@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®