From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754764AbbIRWcp (ORCPT ); Fri, 18 Sep 2015 18:32:45 -0400 Received: from mout.gmx.net ([212.227.15.15]:61666 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753375AbbIRWco (ORCPT ); Fri, 18 Sep 2015 18:32:44 -0400 From: Christian Engelmayer To: airlied@linux.ie Cc: thellstrom@vmware.com, syeh@vmware.com, daniel.vetter@ffwll.ch, jakob@vmware.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Christian Engelmayer Subject: [PATCH 2/2] drm/vmwgfx: Fix uninitialized return in vmw_kms_helper_dirty() Date: Sat, 19 Sep 2015 00:32:24 +0200 Message-Id: <1442615544-22203-1-git-send-email-cengelma@gmx.at> X-Mailer: git-send-email 1.9.1 X-Provags-ID: V03:K0:YMsf1Cqp1by9Hu2VMOnVQ6k4kj1kBYhuoDfnKEalG+ALVLvBHwP GBrQDOMKE5adYR7zbNAT+yGhHpcwZ4wCHQwex1T7K7CFM+5r9Bg1aVbQ1WlCGJOMBZO9ujr 2y1XL2RAq34H1GsbJfOOF5N3pJbGN7DbnfxAHAdKKsRsUX0ShHegTnEwMvyw11N/RzibQmV tpc35T5kpRfAPeb1fSF0w== X-UI-Out-Filterresults: notjunk:1;V01:K0:2zxoZ1CB//o=:bRJZE9/hp22UaWBL3ji8y5 VubucQxjfI2ogHpQUlzrxw1T8C2Oib6Lerq+dyRj+eBKuW5M3+ekMrSRgXs8cwD16q+t5UcmI cvylLwrlGJC00JyLLYjoOWXdvLiLOuzx7Yv476JB8HrDYF3bz7uHg/QezjVI7I14TI4Zo5GyP CukekVajoloZDmkZYhM/9fjEsgFehX2U/qXG7xaa82iZA4SsmFLYJC/pdgjf7azmunKygXn+d AqiGJEk/JUvukhk0X1L0YdzavfS82vAAHtlBt0nhWhgzG1W8oN44qx4otB8DVYrynu83OwAm+ ToZICm1v8kK1Y3vvatovezQweBxHm3lFkgY7baqa7PRVamjrYR5UK9lNU5ZS4S+53XWIF+1PK aJCxoZHHtFZbb1iABDDDvn/OfB03wG2IoIIiEuhqh9jruO7WOygX/7EYZQtSsTixPKXhfyKA9 aaGx38/3gpxAno0rR3z6OgaRJ19bD3s4ZyRDpoRrXhAkjF8lvGND0Vfx92wA+GW9n9xA4Kxlk BXGD500iZngkfPq0ZH2SgAYzM3CGzSDxztOihYyWJ+2mNtkapqmbTR7nyCvo7bRsHZL3LxLhL 8W0O/yJ4cXMFEPHVo/wD9Xepq0H93DIzKApo3TgERYBcDAVpIiJrgewZRABY2+4bUT2QXcRaW L2xUZr2PmVrIam5uLmaXml3sC4jhzcaTZa2PkxDwXQ4B6MMRhIUKAqcjDK+wOCOhQktD3/POk Wrpt5IEalQRiiTLM Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function vmw_kms_helper_dirty() uses the uninitialized variable ret as return value. Make the result deterministic and directly return as the variable is unused anyway. Detected by Coverity CID 1324255. Signed-off-by: Christian Engelmayer --- Compile tested only. Applies against linux-next. --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 61fb7f3de311..15a6c01cd016 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -1685,7 +1685,6 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv, struct drm_crtc *crtc; u32 num_units = 0; u32 i, k; - int ret; dirty->dev_priv = dev_priv; @@ -1711,7 +1710,7 @@ int vmw_kms_helper_dirty(struct vmw_private *dev_priv, if (!dirty->cmd) { DRM_ERROR("Couldn't reserve fifo space " "for dirty blits.\n"); - return ret; + return -ENOMEM; } memset(dirty->cmd, 0, dirty->fifo_reserve_size); } -- 1.9.1