From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755387AbbITOOX (ORCPT ); Sun, 20 Sep 2015 10:14:23 -0400 Received: from mx1.polytechnique.org ([129.104.30.34]:43292 "EHLO mx1.polytechnique.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755114AbbITOOW (ORCPT ); Sun, 20 Sep 2015 10:14:22 -0400 From: Nicolas Iooss To: Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Mauro Carvalho Chehab , kernel@stlinux.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Iooss Subject: [PATCH 1/2] [media] c8sectpfe: initialize err in load_slim_core_fw Date: Sun, 20 Sep 2015 16:14:06 +0200 Message-Id: <1442758447-1474-1-git-send-email-nicolas.iooss_linux@m4x.org> X-Mailer: git-send-email 2.5.2 X-AV-Checked: ClamAV using ClamSMTP at svoboda.polytechnique.org (Sun Sep 20 16:14:21 2015 +0200 (CEST)) X-Spam-Flag: No, tests=bogofilter, spamicity=0.000000, queueID=46F711408EFB4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org load_slim_core_fw() uses a for loop with !err in its condition without first initializing err. Fix this by setting err to 0 in its definition. Signed-off-by: Nicolas Iooss --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c index 486aef50d99b..a424339b18bc 100644 --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c @@ -1097,7 +1097,7 @@ static int load_slim_core_fw(const struct firmware *fw, void *context) Elf32_Ehdr *ehdr; Elf32_Phdr *phdr; u8 __iomem *dst; - int err, i; + int err = 0, i; if (!fw || !context) return -EINVAL; -- 2.5.2