From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932167AbbIUKRd (ORCPT ); Mon, 21 Sep 2015 06:17:33 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:30132 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756539AbbIUKQ0 (ORCPT ); Mon, 21 Sep 2015 06:16:26 -0400 X-AuditID: cbfec7f5-f794b6d000001495-21-55ffd8f634d5 From: Marek Szyprowski To: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski , Robert Baldyga , John Youn , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz Subject: [PATCH v3 3/4] usb: dwc2: fix unbalanced phy control Date: Mon, 21 Sep 2015 12:16:11 +0200 Message-id: <1442830572-6765-4-git-send-email-m.szyprowski@samsung.com> X-Mailer: git-send-email 1.9.2 In-reply-to: <1442830572-6765-1-git-send-email-m.szyprowski@samsung.com> References: <1442830572-6765-1-git-send-email-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplluLIzCtJLcpLzFFi42I5/e/4Vd1vN/6HGnxYbmOxccZ6Vovdpy8x Wrx+YWhxedccNosZ5/cxWSxa1spssfbIXXaLB4d3sjtwePRtWcXosWX/Z0aPz5vkApijuGxS UnMyy1KL9O0SuDJeTZnDVPCbtWLatI2MDYzfWboYOTkkBEwkLveeY4OwxSQu3FsPZgsJLGWU aNgd1sXIBWQ3MUmsWf0OLMEmYCjR9bYLzBYRSJDoW97PBlLELPCUUWLii/NAUzk4hAVsJU4v KACpYRFQlTj17DEziM0r4C4x9fJyqMVyEv9frmACsTkFPCR+/74Btdhdor1vM+sERt4FjAyr GEVTS5MLipPSc430ihNzi0vz0vWS83M3MUIC6esOxqXHrA4xCnAwKvHwOgr8DxViTSwrrsw9 xCjBwawkwqszCyjEm5JYWZValB9fVJqTWnyIUZqDRUmcd+au9yFCAumJJanZqakFqUUwWSYO TqkGxtTb93PEC6/9myCmZfiQedPiSUKzFv3bzdhcZjGZp8Ws/8fRzLkCu23KjbTVPsguUDvn qm7XGvbpQSXntfqcydeslBgPTDn3q88rTeypw4Fzh07wRz26MffF7v0/JkdrXmSc9MdLREzi 2nLmj4fEhZgV7W9+tvOfdzdZ0n0bo8YdzUOv3BkMapRYijMSDbWYi4oTAcws/BIgAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Even when DWC2 is in (internal) suspended state, it should disable PHY in suspend and then enable it in resume. This patch fixes unbalanced PHY control sequence. Signed-off-by: Marek Szyprowski --- drivers/usb/dwc2/platform.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 3d1f82d..f8ab538 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -290,8 +290,6 @@ static int __maybe_unused dwc2_suspend(struct device *dev) if (dwc2_is_device_mode(dwc2)) { ret = dwc2_hsotg_suspend(dwc2); } else { - if (dwc2->lx_state == DWC2_L0) - return 0; phy_exit(dwc2->phy); phy_power_off(dwc2->phy); -- 1.9.2