From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756414AbbIUNxD (ORCPT ); Mon, 21 Sep 2015 09:53:03 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756877AbbIUNgQ (ORCPT ); Mon, 21 Sep 2015 09:36:16 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-c6-560007ce78f3 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Sebastian Reichel Subject: [PATCH 11/38] HSI: omap_ssi: fix handling ida_simple_get result Date: Mon, 21 Sep 2015 15:33:43 +0200 Message-id: <1442842450-29769-12-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgluLIzCtJLcpLzFFi42I5/e/4Vd1z7AxhBtO/6VrcWneO1WLjjPWs Fpd3zWGzWHvkLrvF6d0lDqwem1Z1snn0bVnF6PF5k1wAcxSXTUpqTmZZapG+XQJXxpqvcxkL /rFXbDhwiamB8TZbFyMnh4SAicSVV7NZIWwxiQv31gPFuTiEBJYySsz8/5sVwmlikljdd5sF pIpNQFPi7+abYN0iAgoSm3ufgRUxC2xilDhz/jkTSEJYwEOid+ZldhCbRUBV4u/RHmYQm1fA ReLEqX0sEOvkJE4emwy2mhMofuDgF7C4kICzxIElR5gmMPIuYGRYxSiaWppcUJyUnmuoV5yY W1yal66XnJ+7iRESLl92MC4+ZnWIUYCDUYmH10Hgf6gQa2JZcWXuIUYJDmYlEV6dWUAh3pTE yqrUovz4otKc1OJDjNIcLErivHN3vQ8REkhPLEnNTk0tSC2CyTJxcEo1MIZuCRepUwpM27Ne /9nuBTqV+403FgmVOpQsyzywplb0f5vCKpHmZ+tmihZ4Fcx6XMmpXJ+foeEaUDJ/Uvs52xfm N9fMmZa6UuS60tLGfpFN6y4x6VZIrDwXMc3gQdWl7qDUSxy6vrOTknLPzNRvVrl86dfpkr17 olrfmSrbXVISj/dx2PXGSYmlOCPRUIu5qDgRAKYN+D4TAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/hsi/controllers/omap_ssi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hsi/controllers/omap_ssi.c b/drivers/hsi/controllers/omap_ssi.c index 089c6c3..5d9225f 100644 --- a/drivers/hsi/controllers/omap_ssi.c +++ b/drivers/hsi/controllers/omap_ssi.c @@ -336,11 +336,10 @@ static int __init ssi_add_controller(struct hsi_controller *ssi, return -ENOMEM; } - ssi->id = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL); - if (ssi->id < 0) { - err = ssi->id; + err = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL); + if (err < 0) goto out_err; - } + ssi->id = err; ssi->owner = THIS_MODULE; ssi->device.parent = &pd->dev; -- 1.9.1