From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932546AbbIUNuY (ORCPT ); Mon, 21 Sep 2015 09:50:24 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:43643 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932266AbbIUNgT (ORCPT ); Mon, 21 Sep 2015 09:36:19 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-c9-560007cf03fb From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Sebastian Reichel Subject: [PATCH 12/38] HSI: omap_ssi_port: fix handling of_get_named_gpio result Date: Mon, 21 Sep 2015 15:33:44 +0200 Message-id: <1442842450-29769-13-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHJMWRmVeSWpSXmKPExsVy+t/xq7rn2RnCDGZvYbG4te4cq8XGGetZ LS7vmsNmsfbIXXaL07tLHFg9Nq3qZPPo27KK0ePzJrkA5igum5TUnMyy1CJ9uwSujLl/cgpa OCtOX5jF3MB4ir2LkYNDQsBE4vYhsy5GTiBTTOLCvfVsXYxcHEICSxklPny/wQThNDFJrFh0 hQmkik1AU+Lv5ptsILaIgILE5t5nrCBFzAKbGCXOnH8OViQsECDR/2kumM0ioCpx+cUXdhCb V8BF4uLbU4wQ6+QkTh6bzApicwLFDxz8wgJiCwk4SxxYcoRpAiPvAkaGVYyiqaXJBcVJ6bmG esWJucWleel6yfm5mxghofJlB+PiY1aHGAU4GJV4eB0E/ocKsSaWFVfmHmKU4GBWEuHVmQUU 4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjt31/sQIYH0xJLU7NTUgtQimCwTB6dUA6Pjftlowy/1 NucsXTK5jk19VOAQKjal+9OKgvXRmX8+zVonuy8mojtmYirjM26Jek9ZtsZFeXrChsFe8p+v 5r/xnyKm9/rTFBaOmBPeE13jmM5bFYZfU2L0feAe1+fyK8hLKnXxvlcXKi5rhu1V14+9//63 2KT3rnERRbdmHlNZUTPt1aU1LUosxRmJhlrMRcWJAKeByX8RAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/hsi/controllers/omap_ssi_port.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c index 1f8652b..d93dd09 100644 --- a/drivers/hsi/controllers/omap_ssi_port.c +++ b/drivers/hsi/controllers/omap_ssi_port.c @@ -1147,13 +1147,13 @@ static int __init ssi_port_probe(struct platform_device *pd) goto error; } - cawake_gpio = of_get_named_gpio(np, "ti,ssi-cawake-gpio", 0); - if (cawake_gpio < 0) { + err = of_get_named_gpio(np, "ti,ssi-cawake-gpio", 0); + if (err < 0) { dev_err(&pd->dev, "DT data is missing cawake gpio (err=%d)\n", - cawake_gpio); - err = -ENODEV; + err); goto error; } + cawake_gpio = err; err = devm_gpio_request_one(&port->device, cawake_gpio, GPIOF_DIR_IN, "cawake"); -- 1.9.1