From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932713AbbIUNvb (ORCPT ); Mon, 21 Sep 2015 09:51:31 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:34733 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932094AbbIUNgR (ORCPT ); Mon, 21 Sep 2015 09:36:17 -0400 X-AuditID: cbfec7f5-f794b6d000001495-3c-560007d0df13 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Jianwei Wang , Alison Wang , David Airlie , dri-devel@lists.freedesktop.org Subject: [PATCH 15/38] drm/layerscape: fix handling fsl_dcu_drm_plane_index result Date: Mon, 21 Sep 2015 15:33:47 +0200 Message-id: <1442842450-29769-16-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDLMWRmVeSWpSXmKPExsVy+t/xq7oX2BnCDPbt5be4te4cq0XvuZNM FstWrWex2DhjPavFla/v2SzW71jKZnF51xw2i7VH7rI7cHj8O9zP5LFz1l12j+3fHrB63O8+ zuTRt2UVo8fnTXIBbFFcNimpOZllqUX6dglcGSfvvmUpuMdeMaF5NmsD4zm2LkYODgkBE4nb h0O7GDmBTDGJC/fWA4W5OIQEljJK3G89zgSSEBJoYpJ4c0EAxGYT0JT4u/kmG4gtIqAgsbn3 GStIA7PAKiaJ49cWMYIkhAVCJJ7ObGACWcAioCpxqD8XJMwr4CLxZ+dSVohlchInj00GszmB 4gcOfmGB2OUscWDJEaYJjLwLGBlWMYqmliYXFCel5xrpFSfmFpfmpesl5+duYoSE2dcdjEuP WR1iFOBgVOLhdRT4HyrEmlhWXJl7iFGCg1lJhFdnFlCINyWxsiq1KD++qDQntfgQozQHi5I4 78xd70OEBNITS1KzU1MLUotgskwcnFINjMdTrwX7/j1Yu3i5fd/yv4JLBNSbgrX1i+990WTU KPBp6XYyn9m5q8lot49tiDD3tICtW1NFqixmPzpt6cR36mlve9V+m7NOBt9/duoaXjOsPszF 8YDRuMfugYDQDKP71+5/ea5lq/TmmftR2anC8tMZCha+VWRKObshrfrZhYCly/SeFvF+V2Ip zkg01GIuKk4EAI/gSXkvAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c index 82be6b8..d1e300d 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c @@ -58,7 +58,8 @@ static void fsl_dcu_drm_plane_atomic_disable(struct drm_plane *plane, struct drm_plane_state *old_state) { struct fsl_dcu_drm_device *fsl_dev = plane->dev->dev_private; - unsigned int index, value, ret; + unsigned int value; + int index, ret; index = fsl_dcu_drm_plane_index(plane); if (index < 0) -- 1.9.1