From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932681AbbIUNuq (ORCPT ); Mon, 21 Sep 2015 09:50:46 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932265AbbIUNgT (ORCPT ); Mon, 21 Sep 2015 09:36:19 -0400 X-AuditID: cbfec7f5-f794b6d000001495-45-560007d1fc01 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Ivan Mikhaylov , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH 18/38] net/ibm/emac: fix type of phy_mode Date: Mon, 21 Sep 2015 15:33:50 +0200 Message-id: <1442842450-29769-19-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphluLIzCtJLcpLzFFi42I5/e/4Vd2L7AxhBhcOiVrcWneO1WLjjPWs FnPOt7BYHGn8x2ZxedccNou1R+6yWxxbIObA7rFl5U0mj8ldz1k9+rasYvT4vEkugCWKyyYl NSezLLVI3y6BK+PO1FcsBbPZKvo/BzUwTmbtYuTkkBAwkejavI4ZwhaTuHBvPVsXIxeHkMBS RoltlxeCJYQEmpgkjn80ArHZBDQl/m6+yQZiiwgoSGzufcYK0sAs8JlR4uCb30xdjBwcwgKW Eif+64HUsAioSjyZd48dxOYVcJFYf3Y7G8QyOYmTxyCO4ASKHzj4hQVil7PEgSVHmCYw8i5g ZFjFKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERJGX3cwLj1mdYhRgINRiYfXUeB/qBBrYllx Ze4hRgkOZiURXp1ZQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8M3e9DxESSE8sSc1OTS1ILYLJ MnFwSjUwOq+POu2Wu+qfxEmL3bUbzu6VPedkfGLGJXvuF4dWsluzOcZIGWhvENs0R1okyHdn z9TXLy8lLCx1vr7jyZnrvr8TVqrtE7pk6xXp/rrgunc402Q7re/fb2s8vra4TXLPCbnjt66u PJqlVuhmfO+Pbs+lX+LdF4SnLU7g4+BZlBdeLt063UzttRJLcUaioRZzUXEiAKRmHRcfAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org phy_mode can be negative. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/net/ethernet/ibm/emac/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/ibm/emac/core.h b/drivers/net/ethernet/ibm/emac/core.h index 28df374..f379e47 100644 --- a/drivers/net/ethernet/ibm/emac/core.h +++ b/drivers/net/ethernet/ibm/emac/core.h @@ -181,7 +181,7 @@ struct emac_instance { struct mal_commac commac; /* PHY infos */ - u32 phy_mode; + int phy_mode; u32 phy_map; u32 phy_address; u32 phy_feat_exc; -- 1.9.1