From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932686AbbIUNrt (ORCPT ); Mon, 21 Sep 2015 09:47:49 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:43643 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932350AbbIUNgX (ORCPT ); Mon, 21 Sep 2015 09:36:23 -0400 X-AuditID: cbfec7f5-f794b6d000001495-47-560007d1aa54 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Giuseppe Cavallaro , netdev@vger.kernel.org Subject: [PATCH 19/38] net: stmmac: fix type of entry variable Date: Mon, 21 Sep 2015 15:33:51 +0200 Message-id: <1442842450-29769-20-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphluLIzCtJLcpLzFFi42I5/e/4Vd2L7AxhBqevalrcWneO1WLjjPWs Fpd3zWGzWHvkLrvFsQViFv9fb2V0YPPo27KK0ePpj73MHp83yQUwR3HZpKTmZJalFunbJXBl fFvUzFzwl71i9p89bA2MH9m6GDk5JARMJGYuWsYMYYtJXLi3HijOxSEksJRR4sbpnWAJIYEm JonjH41AbDYBTYm/m2+CNYsIKEhs7n3GCtLALHCVUWJhXycrSEJYwE5i2q8VLCA2i4CqxKaP H5hAbF4BF4kF568wQmyTkzh5bDJYPSdQ/MDBLywQy5wlDiw5wjSBkXcBI8MqRtHU0uSC4qT0 XCO94sTc4tK8dL3k/NxNjJCw+bqDcekxq0OMAhyMSjy8jgL/Q4VYE8uKK3MPMUpwMCuJ8OrM AgrxpiRWVqUW5ccXleakFh9ilOZgURLnnbnrfYiQQHpiSWp2ampBahFMlomDU6qBUd7yf848 6fUODfMnK0f/mf1jX8Or9a6H/x9z66t+dmbrB/uWVzJ3SiMevbvzk6WkbW3XrYyZGwovB9nW 5hsKaCxvkvDL8JqaNffnRoZ5U8/pbrZUCT9mwOp0pzPiVsflvzzreV5+ZW8OvbH/3s9uyzd/ mQ4pMtdN+CYWLRfX0biB81XL1I8TLimxFGckGmoxFxUnAgBhNiwoFwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Variable can store negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 925f2f8..934143e 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1945,7 +1945,7 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev) { struct stmmac_priv *priv = netdev_priv(dev); unsigned int txsize = priv->dma_tx_size; - unsigned int entry; + int entry; int i, csum_insertion = 0, is_jumbo = 0; int nfrags = skb_shinfo(skb)->nr_frags; struct dma_desc *desc, *first; -- 1.9.1