From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932708AbbIUNrT (ORCPT ); Mon, 21 Sep 2015 09:47:19 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:40457 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932372AbbIUNgX (ORCPT ); Mon, 21 Sep 2015 09:36:23 -0400 X-AuditID: cbfec7f5-f794b6d000001495-55-560007d31107 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Alessandro Zummo , Alexandre Belloni , rtc-linux@googlegroups.com Subject: [PATCH 24/38] rtc: opal: fix type of token Date: Mon, 21 Sep 2015 15:33:56 +0200 Message-id: <1442842450-29769-25-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCLMWRmVeSWpSXmKPExsVy+t/xq7qX2RnCDA7/MbC4te4cq8WSi1fZ LTquLWay2DhjPavF5V1z2CzWHrnLbrG/s4PRgd3jyaaLjB57Jp5k8+jbsorRY/q8n0wenzfJ BbBGcdmkpOZklqUW6dslcGU0z77FXnCRrWLb9PwGxr2sXYycHBICJhIN094zQ9hiEhfurWfr YuTiEBJYyigx988BFginiUniQEsbI0gVm4CmxN/NN9lAbBEBBYnNvc9YQYqYBSYzSaycsgls lLCAscTU5S/BVrAIqErsebSaCcTmFXCRePxjLTvEOjmJk8cmg9VwAsUPHPzCAmILCThLHFhy hGkCI+8CRoZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCFh9XUH49JjVocYBTgYlXh4HQX+ hwqxJpYVV+YeYpTgYFYS4dWZBRTiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3PX+xAhgfTEktTs 1NSC1CKYLBMHp1QDY8T2JyF70/8pXNeftLx7T6W9SNk36bfLvjDMFii441Fk/j7iFfcthoT7 x9TOJ92ZGHhu8XWREOZN9qwf08+db07bPe9D+8LpIacjCno0dTQSYsTFv31eeeoby4mVX6vj uWdbaSmv9hZIOvI6VFmxVJ1HT5pr6ryVLz+E8DHvkIk95b3Y98DFi0osxRmJhlrMRcWJAHrb 8N8nAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The variable can take signed values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/rtc/rtc-opal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-opal.c b/drivers/rtc/rtc-opal.c index 6fbf9e6..590e1a4 100644 --- a/drivers/rtc/rtc-opal.c +++ b/drivers/rtc/rtc-opal.c @@ -152,10 +152,10 @@ exit: /* Set Timed Power-On */ static int opal_set_tpo_time(struct device *dev, struct rtc_wkalrm *alarm) { - u64 h_m_s_ms = 0, token; + u64 h_m_s_ms = 0; struct opal_msg msg; u32 y_m_d = 0; - int rc; + int token, rc; tm_to_opal(&alarm->time, &y_m_d, &h_m_s_ms); -- 1.9.1