From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932564AbbIUNlY (ORCPT ); Mon, 21 Sep 2015 09:41:24 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:43643 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932422AbbIUNg0 (ORCPT ); Mon, 21 Sep 2015 09:36:26 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-fa-560007d66183 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Richard Purdie , Jacek Anaszewski , linux-leds@vger.kernel.org Subject: [PATCH 31/38] leds: tca6507: remove invalid check Date: Mon, 21 Sep 2015 15:34:03 +0200 Message-id: <1442842450-29769-32-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkluLIzCtJLcpLzFFi42I5/e/4Vd1r7AxhBgeW6lrcWneO1WLjjPWs Fr1XnzNaXN41h81i65t1jBZrj9xlt9i96ymrA7vHnvk/WD36tqxi9Pi8SS6AOYrLJiU1J7Ms tUjfLoEr42LXfNaCaewVi/bsYWxg/MvaxcjJISFgItF/9SELhC0mceHeerYuRi4OIYGljBKX n7UyQjhNTBIXvh1hAqliE9CU+Lv5JhuILSKgILG59xkrSBGzwH9Gic9/TjGDJIQFrCTa2m8C dXNwsAioSuxY4gZi8gq4SPxb4gqxTE7i5LHJYEdwAoUPHPwCdoSQgLPEgSVHmCYw8i5gZFjF KJpamlxQnJSea6hXnJhbXJqXrpecn7uJERJAX3YwLj5mdYhRgINRiYfXQeB/qBBrYllxZe4h RgkOZiURXp1ZQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8c3e9DxESSE8sSc1OTS1ILYLJMnFw SjUwFoqt/Lawv3fp0YNPDv69taaeK8h2jerJ9Penc8U4t67+8rSt41PCqyxuh/r/vFklCr4s O6Sa67Pk384/3SWyhpn5f5LRmiNy9myf0sT2zl2h3ZrgyHzlp31Hv+RcPmV9hdNPZIQiZC+9 djhwUiZ6mkE6389jvaFHFpfHNTXPWfKz7NFT98lblViKMxINtZiLihMBWIqAIRwCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org unsigned value cannot be lesser than zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/leds/leds-tca6507.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c index edbecc4..93564f6 100644 --- a/drivers/leds/leds-tca6507.c +++ b/drivers/leds/leds-tca6507.c @@ -713,7 +713,7 @@ tca6507_led_dt_init(struct i2c_client *client) if (of_property_match_string(child, "compatible", "gpio") >= 0) led.flags |= TCA6507_MAKE_GPIO; ret = of_property_read_u32(child, "reg", ®); - if (ret != 0 || reg < 0 || reg >= NUM_LEDS) + if (ret != 0 || reg >= NUM_LEDS) continue; tca_leds[reg] = led; -- 1.9.1