From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932255AbbIUNlT (ORCPT ); Mon, 21 Sep 2015 09:41:19 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932460AbbIUNg0 (ORCPT ); Mon, 21 Sep 2015 09:36:26 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-fe-560007d71309 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Andrew Morton , Alexander Kuleshov , Tony Luck , Wei Yang , linux-mm@kvack.org Subject: [PATCH 33/38] mm/memblock.c: remove invalid check Date: Mon, 21 Sep 2015 15:34:05 +0200 Message-id: <1442842450-29769-34-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBLMWRmVeSWpSXmKPExsVy+t/xq7rX2RnCDA7+kbO4te4cq8Wc9WvY LDbOWM9qsX7nZ3aLy7vmsFncW/Of1WLtkbvsFm8u3GOxaLq1k9mB02PnrLvsHov3vGTy2PRp ErvHiRm/WTweHNrM4tG3ZRWjx+dNcgHsUVw2Kak5mWWpRfp2CVwZz6++ZS3YxFZxruUASwPj EtYuRk4OCQETif9/VrJD2GISF+6tZ+ti5OIQEljKKNH16AY7hNPEJPHgyH+wDjYBTYm/m2+y gdgiAgoSm3ufsYIUMQucYJLYffoQWJGwgJXE3wvNQN0cHCwCqhJLl+qChHkFXCRWvF3OCLFN TuLksclg5ZxA8QMHv7CA2EICzhIHlhxhmsDIu4CRYRWjaGppckFxUnquoV5xYm5xaV66XnJ+ 7iZGSPh92cG4+JjVIUYBDkYlHl4Hgf+hQqyJZcWVuYcYJTiYlUR4dWYBhXhTEiurUovy44tK c1KLDzFKc7AoifPO3fU+REggPbEkNTs1tSC1CCbLxMEp1cDI+eZPgjYbt8OCdTZZM3jK86Pl j3uu9Dh64ErBtx86tQZlvZfSshTkOxUPywrrBWjE+Wy4EfHe93jE8aefg//tf9Gm2/2+sPR/ 14XoT9X2i97Vbs/Qb+Kxfe/5Ys75m90H519LCP3Gzm/dV+0trM42pdv/H4dOkZ97j7fmSiH2 Kzdu8ibx5ymxFGckGmoxFxUnAgCmLjflOwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unsigned value cannot be lesser than zero. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index d300f13..aeb5148 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -837,7 +837,7 @@ void __init_memblock __next_reserved_mem_region(u64 *idx, { struct memblock_type *type = &memblock.reserved; - if (*idx >= 0 && *idx < type->cnt) { + if (*idx < type->cnt) { struct memblock_region *r = &type->regions[*idx]; phys_addr_t base = r->base; phys_addr_t size = r->size; -- 1.9.1