From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932364AbbIUNlU (ORCPT ); Mon, 21 Sep 2015 09:41:20 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:34762 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932462AbbIUNg0 (ORCPT ); Mon, 21 Sep 2015 09:36:26 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-0a-560007d91a81 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , David Airlie , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , dri-devel@lists.freedesktop.org Subject: [PATCH 38/38] drm/radeon: simplify boot level calculation Date: Mon, 21 Sep 2015 15:34:10 +0200 Message-id: <1442842450-29769-39-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJLMWRmVeSWpSXmKPExsVy+t/xq7o32RnCDHoPi1rcWneO1aL33Ekm i2l3drNabJyxntXi7X0g68rX92wWl3fNYbNYe+QuuwOHR+ulv2we2789YPW4332cyaNvyypG j8+b5AJYo7hsUlJzMstSi/TtErgyvs08wFawWKCi+3p8A+Np3i5GTg4JAROJ5unvWSBsMYkL 99azdTFycQgJLGWU2Hz3IQuE08Qk0fv2EitIFZuApsTfzTfZQGwRAQWJzb3PWEGKmAX2M0l8 nfUGLCEs4CTx99wKdhCbRUBVouXRLWYQm1fAReLB9gOsEOvkJE4emwxmcwLFDxz8AnaGkICz xIElR5gmMPIuYGRYxSiaWppcUJyUnmuoV5yYW1yal66XnJ+7iRESYF92MC4+ZnWIUYCDUYmH 10Hgf6gQa2JZcWXuIUYJDmYlEV6dWUAh3pTEyqrUovz4otKc1OJDjNIcLErivHN3vQ8REkhP LEnNTk0tSC2CyTJxcEo1MC7r6830z7eazuLI89d1w2avvR32Dcf+Tc8P6LlxYTs/r/wiD5Xn n0z688+Wxm4JvGS2JJS1/9eMtecNX7bYKsywFXtvzxPMmy+fFr9e9W+faZa89M2Sh/mHC1/+ +5L0xywltvSGvZISu2X4RG23ewn5O3o+x06bdFrk4C0dtW81Z0P/TswWV2Ipzkg01GIuKk4E AHTLqFUsAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch simplifies the code without changing behaviour, but most problably there is a bug somewhere else. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/amd/amdgpu/kv_dpm.c | 11 +---------- drivers/gpu/drm/radeon/kv_dpm.c | 11 +---------- 2 files changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c b/drivers/gpu/drm/amd/amdgpu/kv_dpm.c index 94ec04a..f9cfc56 100644 --- a/drivers/gpu/drm/amd/amdgpu/kv_dpm.c +++ b/drivers/gpu/drm/amd/amdgpu/kv_dpm.c @@ -1622,19 +1622,10 @@ static int kv_update_samu_dpm(struct amdgpu_device *adev, bool gate) static u8 kv_get_acp_boot_level(struct amdgpu_device *adev) { - u8 i; struct amdgpu_clock_voltage_dependency_table *table = &adev->pm.dpm.dyn_state.acp_clock_voltage_dependency_table; - for (i = 0; i < table->count; i++) { - if (table->entries[i].clk >= 0) /* XXX */ - break; - } - - if (i >= table->count) - i = table->count - 1; - - return i; + return table->count ? 0 : -1; } static void kv_update_acp_boot_level(struct amdgpu_device *adev) diff --git a/drivers/gpu/drm/radeon/kv_dpm.c b/drivers/gpu/drm/radeon/kv_dpm.c index 2d71da4..dc9aab5 100644 --- a/drivers/gpu/drm/radeon/kv_dpm.c +++ b/drivers/gpu/drm/radeon/kv_dpm.c @@ -1546,19 +1546,10 @@ static int kv_update_samu_dpm(struct radeon_device *rdev, bool gate) static u8 kv_get_acp_boot_level(struct radeon_device *rdev) { - u8 i; struct radeon_clock_voltage_dependency_table *table = &rdev->pm.dpm.dyn_state.acp_clock_voltage_dependency_table; - for (i = 0; i < table->count; i++) { - if (table->entries[i].clk >= 0) /* XXX */ - break; - } - - if (i >= table->count) - i = table->count - 1; - - return i; + return table->count ? 0 : -1; } static void kv_update_acp_boot_level(struct radeon_device *rdev) -- 1.9.1