From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932822AbbIUNyX (ORCPT ); Mon, 21 Sep 2015 09:54:23 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:40457 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756848AbbIUNgO (ORCPT ); Mon, 21 Sep 2015 09:36:14 -0400 X-AuditID: cbfec7f5-f794b6d000001495-1f-560007cb0737 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH 03/38] drm/i915: fix handling gen8_emit_flush_coherentl3_wa result Date: Mon, 21 Sep 2015 15:33:35 +0200 Message-id: <1442842450-29769-4-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrELMWRmVeSWpSXmKPExsVy+t/xq7qn2RnCDH78U7K4te4cq0XvuZNM FhtnrGe1WH5mHbPFla/v2SxmT9jMZLH88npGi8u75rBZrD1yl92B02PxnpdMHtu/PWD1mHcy 0ON+93Emj74tqxg9Pm+SC2CL4rJJSc3JLEst0rdL4MrY0vybsWAGR0XXrtXsDYzf2LoYOTkk BEwkpk/sYoWwxSQu3FsPFOfiEBJYyihx+u0pVginiUli1vz/TCBVbAKaEn833wTrFhFQkNjc +wysiFngNJPE4infGUESwgIhEitn9LOA2CwCqhIne6YAFXFw8Ao4S9zuCYPYJidx8thksM2c Ai4SBw5+ASsXAio5sOQI0wRG3gWMDKsYRVNLkwuKk9JzjfSKE3OLS/PS9ZLzczcxQkLu6w7G pcesDjEKcDAq8fA6CvwPFWJNLCuuzD3EKMHBrCTCqzMLKMSbklhZlVqUH19UmpNafIhRmoNF SZx35q73IUIC6YklqdmpqQWpRTBZJg5OqQbGxSfl/ilPenhtSlHxwwPT1Z3Un254yLgqNyP6 twuLweIXeus0N3NzhV32rSxZbbNdUnbjobbt2iyZx2dU8ZcJxS23cmvefeeG289XcpzZq5eV bDhdtGJuSqpvM+eWjYm/s3+ZfT+Xvk5rtnANK9/cyBj5X39n+3L+N9iyI2VRumys5tQZ5z5f VGIpzkg01GIuKk4EAC7IQNE1AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/i915/intel_lrc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index fe06accb0..ff9a481 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@ -1254,9 +1254,10 @@ static int gen8_init_indirectctx_bb(struct intel_engine_cs *ring, /* WaFlushCoherentL3CacheLinesAtContextSwitch:bdw */ if (IS_BROADWELL(ring->dev)) { - index = gen8_emit_flush_coherentl3_wa(ring, batch, index); - if (index < 0) - return index; + int rc = gen8_emit_flush_coherentl3_wa(ring, batch, index); + if (rc < 0) + return rc; + index = rc; } /* WaClearSlmSpaceAtContextSwitch:bdw,chv */ -- 1.9.1