From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932765AbbIUNxG (ORCPT ); Mon, 21 Sep 2015 09:53:06 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:40457 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756868AbbIUNgP (ORCPT ); Mon, 21 Sep 2015 09:36:15 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-b7-560007cc4b81 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Doug Ledford , Sean Hefty , Hal Rosenstock , Greg Kroah-Hartman , linux-rdma@vger.kernel.org, devel@driverdev.osuosl.org Subject: [PATCH 04/38] IB/ehca: fix handling idr_alloc result Date: Mon, 21 Sep 2015 15:33:36 +0200 Message-id: <1442842450-29769-5-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHLMWRmVeSWpSXmKPExsVy+t/xq7pn2BnCDA6fYbK4te4cq8XGGetZ Lfac+cVu8fL8B1aL5sXr2Sw2bp7IaHF51xw2i2eHelks1h65y27RvH4DiwOXx719h1k8ds66 y+6xeM9LJo/9c9ewe7zfd5XNo2/LKkaPz5vkAtijuGxSUnMyy1KL9O0SuDI+zj3GVHCKv+LQ vd3sDYwveLoYOTkkBEwklj3awA5hi0lcuLeerYuRi0NIYCmjxIXZM5khnCYmic7925lAqtgE NCX+br7JBmKLCChIbO59xgpSxCzwkUmi9+dSZpCEsICtxIupn1hBbBYBVYnPP16AreAVcJb4 /qmJBWKdnMTJY5PBajgFXCQOHPwCFhcCqjmw5AjTBEbeBYwMqxhFU0uTC4qT0nMN9YoTc4tL 89L1kvNzNzFCQvHLDsbFx6wOMQpwMCrx8DoI/A8VYk0sK67MPcQowcGsJMKrMwsoxJuSWFmV WpQfX1Sak1p8iFGag0VJnHfurvchQgLpiSWp2ampBalFMFkmDk6pBsbgkvtaNc/itQ8cvNKz z1oqmN94ql63qXfqIdkXvnuC7s1f2Re4XjEm3OeLWqBimEbMeqFqTaYi5wfzj27utp715tBJ u5Qk3RthP5w/HV7X9+z5spV55vNrvzHYTWqZXqp15PjKxU8dA2vTRR3lXzcGrLwadHj/+xXO 5kl7hV38TL7YKOvcFVViKc5INNRiLipOBACHmLq+QQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/staging/rdma/ehca/ehca_cq.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rdma/ehca/ehca_cq.c b/drivers/staging/rdma/ehca/ehca_cq.c index 9b68b17..ea1b5c1 100644 --- a/drivers/staging/rdma/ehca/ehca_cq.c +++ b/drivers/staging/rdma/ehca/ehca_cq.c @@ -130,7 +130,7 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, void *vpage; u32 counter; u64 rpage, cqx_fec, h_ret; - int ipz_rc, i; + int rc, i; unsigned long flags; if (attr->flags) @@ -170,16 +170,17 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, idr_preload(GFP_KERNEL); write_lock_irqsave(&ehca_cq_idr_lock, flags); - my_cq->token = idr_alloc(&ehca_cq_idr, my_cq, 0, 0x2000000, GFP_NOWAIT); + rc = idr_alloc(&ehca_cq_idr, my_cq, 0, 0x2000000, GFP_NOWAIT); write_unlock_irqrestore(&ehca_cq_idr_lock, flags); idr_preload_end(); - if (my_cq->token < 0) { + if (rc < 0) { cq = ERR_PTR(-ENOMEM); ehca_err(device, "Can't allocate new idr entry. device=%p", device); goto create_cq_exit1; } + my_cq->token = rc; /* * CQs maximum depth is 4GB-64, but we need additional 20 as buffer @@ -195,11 +196,11 @@ struct ib_cq *ehca_create_cq(struct ib_device *device, goto create_cq_exit2; } - ipz_rc = ipz_queue_ctor(NULL, &my_cq->ipz_queue, param.act_pages, + rc = ipz_queue_ctor(NULL, &my_cq->ipz_queue, param.act_pages, EHCA_PAGESIZE, sizeof(struct ehca_cqe), 0, 0); - if (!ipz_rc) { + if (!rc) { ehca_err(device, "ipz_queue_ctor() failed ipz_rc=%i device=%p", - ipz_rc, device); + rc, device); cq = ERR_PTR(-EINVAL); goto create_cq_exit3; } -- 1.9.1