From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932737AbbIUNxn (ORCPT ); Mon, 21 Sep 2015 09:53:43 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:43643 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756853AbbIUNgP (ORCPT ); Mon, 21 Sep 2015 09:36:15 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-b8-560007cc8c9b From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman , lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org Subject: [PATCH 05/38] staging: lustre: fix handling lustre_posix_acl_xattr_filter result Date: Mon, 21 Sep 2015 15:33:37 +0200 Message-id: <1442842450-29769-6-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrILMWRmVeSWpSXmKPExsVy+t/xq7pn2BnCDKbskLW4te4cq0XDtVes FhtnrGe12HPmF7tF8+L1bBaXd81hszh1+AGLxdojd9ktFn9qZnTg9Li37zCLx+I9L5k89s9d w+7RvOgGm0ffllWMHp83yQWwRXHZpKTmZJalFunbJXBlHLumUXCbo6Jx0TXGBsbJ7F2MnBwS AiYS0//NY4GwxSQu3FvP1sXIxSEksJRRYuaNe1BOE5NE5/7tTCBVbAKaEn8332QDsUUEFCQ2 9z5jBSliFrjEJPFjwjzGLkYODmGBaImbi01BalgEVCXOLXrGDhLmFXCWWHQuCWKZnMTJY5NZ QWxOAReJAwe/gB0hBFRyYMkRpgmMvAsYGVYxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn525ihATc lx2Mi49ZHWIU4GBU4uF1EPgfKsSaWFZcmXuIUYKDWUmEV2cWUIg3JbGyKrUoP76oNCe1+BCj NAeLkjjv3F3vQ4QE0hNLUrNTUwtSi2CyTBycUg2MRipvFndcuJN7YElcfXbj1wbO2KkXg33d +HOq1mQ3sy1c+7R41758c0PzfRJeUtce/nXf+UVw2eXHYvMUYjarTLSb6h2kNF1a6FjIvg5O 34Yix0Q2qejly85J/NCw8t70I73q6NUMfd2WivmBE6WepUs5x3340LlbTiercLqIje8J5xc1 oqxKLMUZiYZazEXFiQAOdgsFNAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/staging/lustre/lustre/llite/xattr.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c index 362a87d..dddc1ff 100644 --- a/drivers/staging/lustre/lustre/llite/xattr.c +++ b/drivers/staging/lustre/lustre/llite/xattr.c @@ -175,11 +175,12 @@ int ll_setxattr_common(struct inode *inode, const char *name, } ee_free(ee); } else if (rce->rce_ops == RMT_RSETFACL) { - size = lustre_posix_acl_xattr_filter( + rc = lustre_posix_acl_xattr_filter( (posix_acl_xattr_header *)value, size, &new_value); - if (unlikely(size < 0)) - return size; + if (unlikely(rc < 0)) + return rc; + size = rc; pv = (const char *)new_value; } else -- 1.9.1