From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932345AbbIUNgU (ORCPT ); Mon, 21 Sep 2015 09:36:20 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:40457 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756884AbbIUNgR (ORCPT ); Mon, 21 Sep 2015 09:36:17 -0400 X-AuditID: cbfec7f5-f794b6d000001495-27-560007ccdaa4 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org Subject: [PATCH 06/38] tty: serial: lpc32xx_hs: fix handling platform_get_irq result Date: Mon, 21 Sep 2015 15:33:38 +0200 Message-id: <1442842450-29769-7-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42I5/e/4Vd0z7AxhBhPnmlrcWneO1WLjjPWs Fs2L17NZTNnwgcni8q45bBZnFveyW6w9cpfdgd1j/9w17B59W1YxeqzfcpXF4/MmuQCWKC6b lNSczLLUIn27BK6M6TPmMRWc46j4NOMXawPjbPYuRk4OCQETiRl/v0HZYhIX7q1nA7GFBJYy Siw4KtDFyAVkNzFJdO7fzgSSYBPQlPi7+SZYkYiAgsTm3mesIEXMAv8ZJbZcfQZWJCwQJjHh zRegBAcHi4CqxM2ppSBhXgFnibdHHjNDLJOTOHlsMiuIzSngInHg4BcWiMXOEgeWHGGawMi7 gJFhFaNoamlyQXFSeq6RXnFibnFpXrpecn7uJkZIKH3dwbj0mNUhRgEORiUeXkeB/6FCrIll xZW5hxglOJiVRHh1ZgGFeFMSK6tSi/Lji0pzUosPMUpzsCiJ887c9T5ESCA9sSQ1OzW1ILUI JsvEwSnVwJg9eZ6pZ55seGa7XljNgmeqvK/9Np84OfHR7fpF5l8ZC25Oi6i+FmzgWXl5Eu+a V/3cgXMFrnB8NVb5FJ//Rpmj/H/dG8EtF3IOsToeujBVvCckaIGjrhv7projQXdtln7Q67g1 Y0+ox/EMyYdPPCNDTcMOnlwd66p423q6SGq+bI5/Q9uReCWW4oxEQy3mouJEAHRtBGMhAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- drivers/tty/serial/lpc32xx_hs.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c index e92d7eb..7eb04ae 100644 --- a/drivers/tty/serial/lpc32xx_hs.c +++ b/drivers/tty/serial/lpc32xx_hs.c @@ -691,12 +691,13 @@ static int serial_hs_lpc32xx_probe(struct platform_device *pdev) p->port.mapbase = res->start; p->port.membase = NULL; - p->port.irq = platform_get_irq(pdev, 0); - if (p->port.irq < 0) { + ret = platform_get_irq(pdev, 0); + if (ret < 0) { dev_err(&pdev->dev, "Error getting irq for HS UART port %d\n", uarts_registered); - return p->port.irq; + return ret; } + p->port.irq = ret; p->port.iotype = UPIO_MEM32; p->port.uartclk = LPC32XX_MAIN_OSC_FREQ; -- 1.9.1