From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932819AbbIUNx5 (ORCPT ); Mon, 21 Sep 2015 09:53:57 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:37352 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756850AbbIUNgP (ORCPT ); Mon, 21 Sep 2015 09:36:15 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-c0-560007cdd38f From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Pravin Shelar , "David S. Miller" , netdev@vger.kernel.org, dev@openvswitch.org Subject: [PATCH 08/38] openvswitch: fix handling result of ipv6_skip_exthdr Date: Mon, 21 Sep 2015 15:33:40 +0200 Message-id: <1442842450-29769-9-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> References: <1442842450-29769-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBLMWRmVeSWpSXmKPExsVy+t/xq7pn2RnCDE7NVre4te4cq8XGGetZ Leacb2GxOHp6D7PF5V1z2CzWHrnLbnFsgZjF35vPmB04PLasvMnkceDodhaPZzf/M3r0bVnF 6PF5k1wAaxSXTUpqTmZZapG+XQJXxpWd91kLrrNV7P/UzNbAeJm1i5GTQ0LAROLOzQlMELaY xIV769m6GLk4hASWMko8WvaXEcJpYpJoXrqYGaSKTUBT4u/mm2wgtoiAgsTm3mesIEXMAj1M EsdP3QTq4OAQFvCW+NxuBlLDIqAqsfH1PxYQm1fAWeJSRzs7xDY5iZPHJoNdwSngInHg4Bew GiGgmgNLjjBNYORdwMiwilE0tTS5oDgpPddQrzgxt7g0L10vOT93EyMkvL7sYFx8zOoQowAH oxIPr4PA/1Ah1sSy4srcQ4wSHMxKIrw6s4BCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeefueh8i JJCeWJKanZpakFoEk2Xi4JRqYMwr45Q3Crx8/Ngs3oTy4vKHrc4b9j9dKH3+U1XxXWbhPWnZ j83b5DLmbD2xuXPGh+ADu9NtvBz6akvMd7Ynl90L+BzW3aCnfv/zubPKrRILv/+b+3WLjtP+ nkyWvFWvnt7RyG3NvWuWbLTU2d24/JUQv5q4xyO9y2vNpmjJTVHRPXrn6HPffCWW4oxEQy3m ouJEAHHBeeUrAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda --- net/openvswitch/conntrack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c index 002a755..fde3391 100644 --- a/net/openvswitch/conntrack.c +++ b/net/openvswitch/conntrack.c @@ -253,7 +253,7 @@ static int ovs_ct_helper(struct sk_buff *skb, u16 proto) const struct nf_conntrack_helper *helper; const struct nf_conn_help *help; enum ip_conntrack_info ctinfo; - unsigned int protoff; + int protoff; struct nf_conn *ct; ct = nf_ct_get(skb, &ctinfo); -- 1.9.1