From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757130AbbIUPFe (ORCPT ); Mon, 21 Sep 2015 11:05:34 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:33257 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756914AbbIUPBf (ORCPT ); Mon, 21 Sep 2015 11:01:35 -0400 From: Peter Senna Tschudin To: balbi@ti.com, stern@rowland.harvard.edu, sergei.shtylyov@cogentembedded.com, standby24x7@gmail.com, pmladek@suse.cz, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Cc: Peter Senna Tschudin Subject: [PATCH 08/14] RFC: usb/host/fotg210: convert macro to inline function Date: Mon, 21 Sep 2015 17:01:12 +0200 Message-Id: <1442847678-7970-9-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1442847678-7970-1-git-send-email-peter.senna@gmail.com> References: <20150915165002.GP19948@saruman.tx.rr.com> <1442847678-7970-1-git-send-email-peter.senna@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch convert the macro speed_char in an inline function. The goal of this patch is to make the code easier to read. Signed-off-by: Peter Senna Tschudin --- drivers/usb/host/fotg210-hcd.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index 4032ed0..82cd5da 100644 --- a/drivers/usb/host/fotg210-hcd.c +++ b/drivers/usb/host/fotg210-hcd.c @@ -331,17 +331,22 @@ struct debug_buffer { size_t alloc_size; }; -#define speed_char(info1)({ char tmp; \ - switch (info1 & (3 << 12)) { \ - case QH_FULL_SPEED: \ - tmp = 'f'; break; \ - case QH_LOW_SPEED: \ - tmp = 'l'; break; \ - case QH_HIGH_SPEED: \ - tmp = 'h'; break; \ - default: \ - tmp = '?'; break; \ - } tmp; }) +static inline char speed_char(u32 scratch) +{ + switch (scratch & (3 << 12)) { + case QH_FULL_SPEED: + return 'f'; + + case QH_LOW_SPEED: + return 'l'; + + case QH_HIGH_SPEED: + return 'h'; + + default: + return '?'; + } +} static inline char token_mark(struct fotg210_hcd *fotg210, __hc32 token) { -- 2.1.0