From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756956AbbIUPeJ (ORCPT ); Mon, 21 Sep 2015 11:34:09 -0400 Received: from mail-bl2on0119.outbound.protection.outlook.com ([65.55.169.119]:58464 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753223AbbIUPeE (ORCPT ); Mon, 21 Sep 2015 11:34:04 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=freescale.com; From: =?UTF-8?q?Vincent=20Stehl=C3=A9?= To: CC: , =?UTF-8?q?Vincent=20Stehl=C3=A9?= , Oleg Nesterov , "Alexander Viro" , Subject: [PATCH] fs/super.c: use && instead of & for warn_on condition Date: Mon, 21 Sep 2015 17:18:34 +0200 Message-ID: <1442848714-6784-1-git-send-email-vincent.stehle@freescale.com> X-Mailer: git-send-email 2.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD056;1:Z2BSS22k13HMCsjHWT6mvaSQLfHFQn+We2sI6S70AYauY3DR6B+z8SBmOsWoqciUJ6xvIltTZ3hgkl8mn/KKgN8azyNqTyqdXf9YFVrGCmj05rvrSGTtdR1MJ1UlWU1aCQtB/ujSAzIMPRUmZqO+2fZ8JpgLbISO6NG2uF/iUr9RSDoxbLmgkUblxQeE17ySECrM5D9rSImmHyd2QEOFvvMR1b0Oag7VW0uBgfDK47aZ6pz82rk8rszOzZQ3kshQB9xEA8yH+dWjiBChQwHA6MD/BgKu8LmNdEM0aqF/OB/RVqjBscGPNPAZs3ujRpcMTMKtOwdNNW8dW4CHNtm4pGzBGeEEp+BVBCu+kGV8UgzZQHhN0ZK2wJ3fqdt2HCjHY61FScLTeib7uOHPRPX7ww== X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(1110001)(1109001)(339900001)(199003)(189002)(46102003)(57986006)(97736004)(50466002)(50986999)(62966003)(33646002)(83796002)(36756003)(23676002)(19580405001)(19580395003)(86362001)(16796002)(6806004)(50226001)(110136002)(5001860100001)(189998001)(5001960100002)(4001540100001)(47776003)(81156007)(87936001)(85426001)(229853001)(64706001)(5001830100001)(5007970100001)(92566002)(5820100001)(105606002)(46656002)(106466001)(2351001)(68736005)(77156002)(70036007);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0301MB1312;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1312;2:f8CcaLsv3U0DzvfqsXPIRQpgonXoX+R7HwNQsW5VdS1M+pROQ4OrKLzxevSAkwXFG5FW7EltXxpohTwEv0DD+bXwyhGtrIc+BwYsgXWD4Sop6lEUcKamggcQ+my2T0BsGj8uKs7964pPZp1C2cBN2TpTLevRAZZr4DnFhBgysJg=;3:zV5iYPzFWkfzS/x1QF+Gjc5+WVf7DTi6ME7u9p4qAIuAx2ayFzNA3/UAyCRhp5brSm+C6n3+JG+p0uzibfcC8xeXt94YL3LX2loyqR05jD4se+zRQTBZOQd6ueuNJnFYFxx4fqxJDU9ReaB14zuO5dbIhBS/i+SSSJS8nNfK02BdzpzUPEJH7HIwB21c2gaEBxozymNUaicwetZosVy9dfKEc0sghkn+eO5aub72CG4=;25:x6tF+44UU7H9f/M16JxBrU6A+FyZfxCW6Yijp8pWFk9qEn8886NmI9JgzfLoI4DRfRcVf9DXZ3VoyaJVGBoHU5DyAYpZmA4NiPv5IsoA4NFjRrcRHNU/VXv2YW/YuTydPyz9jgblUfs+u9OU7B2NGTWYLv8KprDDBR33YgCNESlTW0WubPuwTgF2zeUni2mbICqnQ36jCfGsOLQkZ3436ur8OnLFN8MiKXyV4E4D4TB4lcxoL/88Z4YrUYie4VmXKQBgDwF/mRZjh108jW0vdw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB1312; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1312;20:Dh0fCdP7gPWyeVpGBTwX7IySZIAPlkWlkzf9tGT1fBjMbH8fOOJMBC1/uOcqdZRIK+hyjf2qXxNgpb0v7S7tACIVa9Y/Aa3tjW2DwU76sa3G4/fJRvguhUxzOBDzBIv0Jo7UU5uGxu8LXnO4QCdDxj0FxiwZBAOWt4xSjYu8VujMiHbazzt6IkTUUbsH8Ljwl9q5b0ZUtBixzbWyJjMbF8HYrDWC5lBvhM10iVsgtsfWqDEKkR3RIQSHESaiiojjJNL6mXId3iQQP4KIFk9cYWQJi9MMvWBVVLnA2OyW9TJUIh46mQTNs7dQOBnYpj4lPOJSdwugHZbHqqHJDXBFJSlCyEGZHWbfpuCJlsw2QvQ=;4:+K0FBMRPea7b8AQAXmW7NAH0I2Wy8A+WYtTo9xn4PNBaJ3CurOvj3FyME+lERVBsmvT8QNDBZRx+VNfpFyB8KqP3eSiZOq5xo9xDJxIQoZoOnkomH7hsOaexUGpdQtgEl89Lc584lrYkHCQYbe1NErl4urCAeZAw0oPMDme/+PbftbsT9b50AzhPkuQtTIZZmJJY+SzqKJq4mC3OoNow8V/onPjBIbt2xBhHE6Za1nNCQCYQzVB32F0XH9uS371Y0HMQ3WvP7CJZAH804U69edr1lrIIFXKB37l8HEcY8S7uoadX4SvSJXwgyPbRo3eWudtnAnRhIKCnRLjloqveP50euwJFnQ7i1Ie0zlLKUl8= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(520078)(520075)(5005006)(3002001);SRVR:DM2PR0301MB1312;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0301MB1312; X-Forefront-PRVS: 07063A0A30 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjAzMDFNQjEzMTI7MjM6ZDViY3k3RTlFd3dlVnNQOHMxaGxFUEJx?= =?utf-8?B?Zi8wWXNKdzlkNDVYeXdXdUMzdkV2NEowc1FBMkpTbktvQkJuS01HdkUxUTMx?= =?utf-8?B?MFhOQzMvekZENVhXODJWZjQ5QkR2K2QranM5TitMa2dLMUNHYXZLbXlrM2ph?= =?utf-8?B?OHZXbjZkTWZUa0dFNk9mWGowMDlmL29USVBaMzBHZStyL0kzcXRwNzVwd0ZW?= =?utf-8?B?QldNRUJtUVFRRW5VeUdJRU96bEJlc2FCTkpxSHJmVndIazY3VkQ3Y1hzd2VS?= =?utf-8?B?dHZ3bHU0aTkyUlBDZFlhSE54MmJMRnVaOHI4SzB6V21CSThSYVp5RVU1azhs?= =?utf-8?B?eG51MFJ0Z1Uwd0JLbEFUbS9uTERKeTJJQ0QrMWxnUVkzRGdvTGlsOTFOd1Ir?= =?utf-8?B?ZjRObWQ1TzYvNXY2MjhycTdjaGl4T1hwZFBGVmI1dlN1dEUwZU44OERQVkY5?= =?utf-8?B?ckczNm1UOFF6RGpJbWo0dFAyY0lDSFNUeUpQWGxCd2pCVXFoNEtENzRNTHZ0?= =?utf-8?B?ZWQ5M2NMbGN5ZTkrdFlwYzVjVURpSFVoazNBTTdybVJZUEpzNm16SnBEcWZs?= =?utf-8?B?NXVIMTBxQnh1cEhyc0t6QmMzUi9scjZUeWVCb1RWZ0wreDcyMWZuSWt1YTBF?= =?utf-8?B?bFoyZzkzRGI0ZGF5aEp3bndZbVhIcDV5N2RRcEx6K3pHWWpFUzlBTitzN1FB?= =?utf-8?B?eTJkdHNQMnNpMTd0ei9BeGJWbUxsZ2hsQnVHT3VseW5nT1BReU9McGlIYkg3?= =?utf-8?B?V0hmYVQ5TDZlbFZLK0dqQjBEOVBTbncyeG1JbjBiQ0ZTemJrQnJhcW42NUZv?= =?utf-8?B?UU9GaHpNRDYva0tKMVF1S1JvVUdKSEEzQ2JRZElpQnJ1TWJNbXp2YTdzS1Nz?= =?utf-8?B?aTFpOUdyRW16ZUt1S2thV0pQajgzV1BWRHBjUk1wOWE4QXdQRFZBVG5zSTlY?= =?utf-8?B?UU5Raml0ZlF3UnIrQmFwaGhFZEdMa0R6S2M5dUJlYThGZjljcjhkdUhXYnVZ?= =?utf-8?B?ZHpSdWx1dkxUMDJaL2hCSGFVZDQ4UUd4ZjJ2YjltRHBoeHdjZEk1YVF1WXBn?= =?utf-8?B?VGU5aWJ2VTkzN0ZZRHNsT0IyWGV3NkZ0MDBFN0NyRWNyS0dCRkVtMTVKRUp6?= =?utf-8?B?THo2TkVNYU5KWGhTemxjZHFpekE4aG9ybW9TdG1VUFlWL1k4SlBaYWJ0T3c1?= =?utf-8?B?Mi9IRnZNQ0ZBanQweWlvTjI3bExqOE5xVUUvZGFYWHZ5bU5BU3dYYTJFMmVL?= =?utf-8?B?Q3dkejY3eFA3YUt2YzBqdFFFY2YyTHBCY1lkSTdxM01WN1A4M0FMcUJFbnpH?= =?utf-8?B?UmVURjVmSHQ1WVNMTVFyVWxPNEEwaENvQkpFSTJXMFVSWm9wWlJCQlVVcHZq?= =?utf-8?B?WHM2TE95Q1hMR2JlQkFaSFl0dWJHSGo1bHZSMStURzJYcG9oN1JZYWpnaDBO?= =?utf-8?B?L1dFMWxPejdwQ2NlUmU0c1NBVzJFOUhPamNGY1lpM2ZZN1MzcGxaejNadkxW?= =?utf-8?B?RitJZnNOb3BPY1F1SmdpMk1sb2lycjNxWEtKMzZtNnM4Tk0rOE1NbzRvdkV0?= =?utf-8?B?a3IyLytqR3Q5SG4rc0ZoR0tMc1plbGtkWjF4aEl5MTh4MG9SNWhZZ0xreFdQ?= =?utf-8?Q?4=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB1312;5:7MPgynCNLmNPEh1fT0EYJAQol8HyG5EYqCsRwR9y+OcdUCVboM6A1B+czv4OK5XTvAv/4vM62mwzr6Ufsfg+1OzTVPZtU010ZcPl8+tCWJo4YzXYkHp1dmS+xSGqcaa3d3PA14d72Esuhh3gNUwrog==;24:IAvh7Ex3ung0Q5obKYSUleIkJuplOvPI99zST/spbKmCAqqEAJR0/EmWdLCDp50wIy8ATjuq6kdQmCKeJgK0s0Z7rrmj6gacq4vic1kXdkc=;20:0VzBVe4HYF9IIv3fOM74X4ERkBnP6TGQ0Kp/BuWA07pCAZX1I56Y7okUs9Sd/++it87grOKqNn+5mWKKeCEv4Q== X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2015 15:18:40.7845 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB1312 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes the following sparse warning: fs/super.c:1202:9: warning: dubious: x & !y Bitwise and logical and are equivalent here, but logical was intended. The generated code is identical, with and without CONFIG_LOCKDEP. Signed-off-by: Vincent Stehlé Cc: Oleg Nesterov Cc: Alexander Viro Cc: trivial@kernel.org --- fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/super.c b/fs/super.c index 954aeb8..7ea56de 100644 --- a/fs/super.c +++ b/fs/super.c @@ -1199,7 +1199,7 @@ int __sb_start_write(struct super_block *sb, int level, bool wait) else ret = percpu_down_read_trylock(sb->s_writers.rw_sem + level-1); - WARN_ON(force_trylock & !ret); + WARN_ON(force_trylock && !ret); return ret; } EXPORT_SYMBOL(__sb_start_write); -- 2.5.1