mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Darren Hart <dvhart@infradead.org>,
	platform-driver-x86@vger.kernel.org
Subject: [PATCH 05/17] platform: x86: remove misuse of IRQF_NO_SUSPEND flag
Date: Mon, 21 Sep 2015 16:47:01 +0100	[thread overview]
Message-ID: <1442850433-5903-6-git-send-email-sudeep.holla@arm.com> (raw)
In-Reply-To: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com>

The IRQF_NO_SUSPEND flag is used to identify the interrupts that should
be left enabled so as to allow them to work as expected during the
suspend-resume cycle, but doesn't guarantee that it will wake the system
from a suspended state, enable_irq_wake is recommended to be used for
the wakeup.

This patch removes the use of IRQF_NO_SUSPEND flags and uses newly
introduce PM wakeup APIs dev_pm_{set,clear}_wake_irq.

Cc: Darren Hart <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/platform/x86/intel_mid_powerbtn.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/intel_mid_powerbtn.c b/drivers/platform/x86/intel_mid_powerbtn.c
index 22606d6b2af3..1fc0de870ff8 100644
--- a/drivers/platform/x86/intel_mid_powerbtn.c
+++ b/drivers/platform/x86/intel_mid_powerbtn.c
@@ -24,6 +24,7 @@
 #include <linux/platform_device.h>
 #include <linux/input.h>
 #include <linux/mfd/intel_msic.h>
+#include <linux/pm_wakeirq.h>
 
 #define DRIVER_NAME "msic_power_btn"
 
@@ -76,14 +77,17 @@ static int mfld_pb_probe(struct platform_device *pdev)
 
 	input_set_capability(input, EV_KEY, KEY_POWER);
 
-	error = request_threaded_irq(irq, NULL, mfld_pb_isr, IRQF_NO_SUSPEND,
-			DRIVER_NAME, input);
+	error = request_threaded_irq(irq, NULL, mfld_pb_isr, 0,
+				     DRIVER_NAME, input);
 	if (error) {
 		dev_err(&pdev->dev, "Unable to request irq %d for mfld power"
 				"button\n", irq);
 		goto err_free_input;
 	}
 
+	device_init_wakeup(&pdev->dev, true);
+	dev_pm_set_wake_irq(&pdev->dev, irq);
+
 	error = input_register_device(input);
 	if (error) {
 		dev_err(&pdev->dev, "Unable to register input dev, error "
@@ -124,6 +128,8 @@ static int mfld_pb_remove(struct platform_device *pdev)
 	struct input_dev *input = platform_get_drvdata(pdev);
 	int irq = platform_get_irq(pdev, 0);
 
+	dev_pm_clear_wake_irq(&pdev->dev);
+	device_init_wakeup(&pdev->dev, false);
 	free_irq(irq, input);
 	input_unregister_device(input);
 
-- 
1.9.1


  parent reply	other threads:[~2015-09-21 15:51 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 15:46 [PATCH 00/17] PM / wakeup : " Sudeep Holla
2015-09-21 15:46 ` [PATCH 01/17] rtc: pl031: " Sudeep Holla
2015-10-02 10:40   ` Linus Walleij
2015-10-02 10:45     ` Sudeep Holla
2015-10-02 13:16       ` Alexandre Belloni
2015-10-05  8:49       ` Linus Walleij
2015-10-03 15:20   ` Alexandre Belloni
2015-09-21 15:46 ` [PATCH 02/17] rtc: ab8500: " Sudeep Holla
2015-10-02 10:41   ` Linus Walleij
2015-10-03 15:20   ` Alexandre Belloni
2015-09-21 15:46 ` [PATCH 03/17] input: tegra-kbc: drop use " Sudeep Holla
2015-10-05  5:44   ` Thierry Reding
2015-10-05 10:24   ` Laxman Dewangan
2015-10-19 17:34     ` Sudeep Holla
2015-10-26  8:37       ` Dmitry Torokhov
2015-09-21 15:47 ` [PATCH 04/17] powerpc: mpic: use IRQCHIP_SKIP_SET_WAKE instead of redundant mpic_irq_set_wake Sudeep Holla
2015-09-22 23:50   ` Scott Wood
2015-09-23  2:35     ` Wang Dongsheng
2015-09-23  3:49       ` Thomas Gleixner
2015-09-23  5:31         ` Wang Dongsheng
2015-09-23  8:00           ` Thomas Gleixner
2015-09-23  4:06   ` Scott Wood
2015-10-19 17:35     ` Sudeep Holla
2015-10-19 17:46       ` Scott Wood
2015-09-21 15:47 ` Sudeep Holla [this message]
2015-10-03 16:09   ` [PATCH 05/17] platform: x86: remove misuse of IRQF_NO_SUSPEND flag Darren Hart
2015-09-21 15:47 ` [PATCH 06/17] rtc: ds1343: " Sudeep Holla
2015-10-03 15:20   ` Alexandre Belloni
2015-09-21 15:47 ` [PATCH 07/17] input: tegra-kbc: drop use " Sudeep Holla
2015-09-21 23:21   ` Lee Jones
2015-09-22  0:43     ` Dmitry Torokhov
2015-09-22 21:08       ` Lee Jones
2015-09-23  8:53         ` Sudeep Holla
2015-09-22 10:00     ` Sudeep Holla
2015-09-25 12:39   ` [PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop " Sudeep Holla
2015-09-25 16:08     ` Lee Jones
2015-09-21 15:47 ` [PATCH 08/17] hwmon: abx500: drop the use of IRQF_NO_SUSPEND Sudeep Holla
2015-09-23 15:32   ` Guenter Roeck
2015-09-21 15:47 ` [PATCH 09/17] MIPS: ttyFDC: replace IRQF_NO_SUSPEND with IRQF_COND_SUSPEND Sudeep Holla
2015-09-21 15:47 ` [PATCH 10/17] tty/serial: st-asc: drop the use of IRQF_NO_SUSPEND Sudeep Holla
2015-09-21 15:47 ` [PATCH 11/17] pm: bf609: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2015-10-19 17:38   ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 12/17] ARM: OMAP2+: " Sudeep Holla
2015-10-12 20:20   ` Tony Lindgren
2015-10-12 20:28     ` Tony Lindgren
2015-10-13 10:42       ` Sudeep Holla
2015-10-13 14:53         ` Tony Lindgren
2015-10-13 15:20           ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 13/17] net: gianfar: " Sudeep Holla
2015-09-21 16:24   ` Manoil Claudiu
2015-09-21 16:38     ` Sudeep Holla
2015-09-21 16:51     ` Thomas Gleixner
2015-09-22 14:04       ` Manoil Claudiu
2015-09-22 15:09         ` Sudeep Holla
2015-09-23 21:20       ` Li Yang
2015-09-23 22:03         ` Thomas Gleixner
2015-09-24 21:17           ` Li Yang
2015-09-24 21:23   ` David Miller
2015-09-21 15:47 ` [PATCH 14/17] media: st-rc: " Sudeep Holla
2015-10-19 17:40   ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 15/17] ir-hix5hd2: drop the use of IRQF_NO_SUSPEND Sudeep Holla
2015-09-23 14:26   ` zhangfei
2015-09-23 14:37     ` Sudeep Holla
2015-09-23 14:50       ` zhangfei
2015-09-21 15:47 ` [PATCH 16/17] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag Sudeep Holla
2015-09-21 18:53   ` Thomas Gleixner
2015-09-22  9:42     ` Sudeep Holla
2015-09-21 15:47 ` [PATCH 17/17] mfd : ab8500/db8500: fix the abuse of IRQF_NO_SUSPEND Sudeep Holla
2015-09-21 23:20   ` Lee Jones
2015-09-22 10:04     ` Sudeep Holla
2015-09-22 21:03       ` Lee Jones
2015-09-23  9:44         ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442850433-5903-6-git-send-email-sudeep.holla@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=dvhart@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®