From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757634AbbIVF3I (ORCPT ); Tue, 22 Sep 2015 01:29:08 -0400 Received: from ozlabs.org ([103.22.144.67]:51630 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbbIVF3G (ORCPT ); Tue, 22 Sep 2015 01:29:06 -0400 Message-ID: <1442899743.18408.5.camel@ellerman.id.au> Subject: Re: [PATCH V2 2/2] powerpc:numa Do not allocate bootmem memory for non existing nodes From: Michael Ellerman To: Raghavendra K T Cc: benh@kernel.crashing.org, paulus@samba.org, anton@samba.org, akpm@linux-foundation.org, nacc@linux.vnet.ibm.com, gkurz@linux.vnet.ibm.com, grant.likely@linaro.org, nikunj@linux.vnet.ibm.com, vdavydov@parallels.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Date: Tue, 22 Sep 2015 15:29:03 +1000 In-Reply-To: <1442282917-16893-3-git-send-email-raghavendra.kt@linux.vnet.ibm.com> References: <1442282917-16893-1-git-send-email-raghavendra.kt@linux.vnet.ibm.com> <1442282917-16893-3-git-send-email-raghavendra.kt@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-09-15 at 07:38 +0530, Raghavendra K T wrote: > > ... nothing Sure this patch looks obvious, but please give me a changelog that proves you've thought about it thoroughly. For example is it OK to use for_each_node() at this point in boot? Is there any historical reason why we did it with a hard coded loop? If so what has changed. What systems have you tested on? etc. etc. cheers > Signed-off-by: Raghavendra K T > --- > arch/powerpc/mm/numa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c > index 8b9502a..8d8a541 100644 > --- a/arch/powerpc/mm/numa.c > +++ b/arch/powerpc/mm/numa.c > @@ -80,7 +80,7 @@ static void __init setup_node_to_cpumask_map(void) > setup_nr_node_ids(); > > /* allocate the map */ > - for (node = 0; node < nr_node_ids; node++) > + for_each_node(node) > alloc_bootmem_cpumask_var(&node_to_cpumask_map[node]); > > /* cpumask_of_node() will now work */