From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758761AbbIVR14 (ORCPT ); Tue, 22 Sep 2015 13:27:56 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:30936 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758373AbbIVR1x (ORCPT ); Tue, 22 Sep 2015 13:27:53 -0400 From: Paul Burton To: CC: Paul Burton , Markos Chandras , Ralf Baechle , Subject: [PATCH 3/5] MIPS: avoid buffer overrun in mips_cm_error_report Date: Tue, 22 Sep 2015 10:26:39 -0700 Message-ID: <1442942801-2883-4-git-send-email-paul.burton@imgtec.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1442942801-2883-1-git-send-email-paul.burton@imgtec.com> References: <1442942801-2883-1-git-send-email-paul.burton@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [192.168.159.189] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 3885c2b463f6 ("MIPS: CM: Add support for reporting CM cache errors") added cases for decoding errors reported by CM3, but leaves the buf variable which is printed as a string uninitialised for cause values other than 1, 2 or 3. Fix by ensuring the buf variable is initialised to an empty string in such cases. Signed-off-by: Paul Burton --- arch/mips/kernel/mips-cm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/kernel/mips-cm.c b/arch/mips/kernel/mips-cm.c index 10524ce..88a8e21 100644 --- a/arch/mips/kernel/mips-cm.c +++ b/arch/mips/kernel/mips-cm.c @@ -366,6 +366,8 @@ void mips_cm_error_report(void) cm3_cmd_group[cmd_group_bits], cm3_cca_bits, 1 << mcp_bits, cm3_tr[cm3_tr_bits], sched_bit); + } else { + buf[0] = 0; } pr_err("CM_ERROR=%llx %s <%s>\n", cm_error, -- 2.5.3