From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934471AbbIVS7v (ORCPT ); Tue, 22 Sep 2015 14:59:51 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:35518 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934333AbbIVS7s (ORCPT ); Tue, 22 Sep 2015 14:59:48 -0400 From: "Felipe F. Tonello" To: linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Peter Chen , Greg Kroah-Hartman , Felipe Balbi , Andrzej Pietrasiewicz , "Felipe F. Tonello" Subject: [PATCH 3/3] usb: gadget: f_midi: free request when usb_ep_queue fails Date: Tue, 22 Sep 2015 19:59:10 +0100 Message-Id: <1442948350-31702-3-git-send-email-eu@felipetonello.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1442948350-31702-1-git-send-email-eu@felipetonello.com> References: <1442948350-31702-1-git-send-email-eu@felipetonello.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fix a memory leak that will occur in this case. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c index e92aff5..e6a114b 100644 --- a/drivers/usb/gadget/function/f_midi.c +++ b/drivers/usb/gadget/function/f_midi.c @@ -550,9 +550,11 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req) int err; err = usb_ep_queue(ep, req, GFP_ATOMIC); - if (err < 0) + if (err < 0) { ERROR(midi, "%s queue req: %d\n", midi->in_ep->name, err); + free_ep_req(ep, req); + } } else { free_ep_req(ep, req); } -- 2.1.4