From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbbIWJzO (ORCPT ); Wed, 23 Sep 2015 05:55:14 -0400 Received: from ozlabs.org ([103.22.144.67]:45604 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753528AbbIWJzM (ORCPT ); Wed, 23 Sep 2015 05:55:12 -0400 Message-ID: <1443002109.9279.1.camel@ellerman.id.au> Subject: Re: [PATCH 2/2] selftests/userfaultfd: improve syscall number definition From: Michael Ellerman To: Andre Przywara Cc: Andrea Arcangeli , Shuah Khan , Andrew Morton , "linux-api@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pavel Emelyanov , Will Deacon Date: Wed, 23 Sep 2015 19:55:09 +1000 In-Reply-To: <56018CA0.8050600@arm.com> References: <1442918756-17892-1-git-send-email-andre.przywara@arm.com> <1442918756-17892-3-git-send-email-andre.przywara@arm.com> <56015C59.5010300@osg.samsung.com> <20150922140625.GH25412@redhat.com> <56018CA0.8050600@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2015-09-22 at 18:15 +0100, Andre Przywara wrote: > On 22/09/15 15:06, Andrea Arcangeli wrote: > > Andre, could you see if linux-next (which includes -mm) works for you > > by just running "cd tools/testing/selftests/vm/ && make"? If there's > > any further change required could you diff it against linux-next? > > This doesn't compile now for me, because it looks into > /usr/include/asm/unistd.h, which I keep to the distribution copy of it. > Also linux/userfaultfd.h is missing, because it's brand new. ... > I guess the right solution would be to hack the Makefile to set the > include path to the kernel's copy of include/uapi, though I am not sure > this works cleanly for different architectures and separate build > directories. I will give this a try ... Not that's not the right solution. The right solution is to export the kernel headers, the Makefile will pick them up (at least in linux-next): $ cd linux $ make headers_install $ ls usr/include/ asm/ asm-generic/ drm/ linux/ misc/ mtd/ rdma/ scsi/ sound/ uapi/ video/ xen/ $ make -C tools/testing/selftests TARGETS=vm ... $ ls tools/testing/selftests/vm/userfaultfd tools/testing/selftests/vm/userfaultfd* cheers