From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754304AbbIWMBx (ORCPT ); Wed, 23 Sep 2015 08:01:53 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:38427 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752135AbbIWMBv (ORCPT ); Wed, 23 Sep 2015 08:01:51 -0400 From: "Felipe F. Tonello" To: linux-usb@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Peter Chen , Greg Kroah-Hartman , Felipe Balbi , Andrzej Pietrasiewicz , "Felipe F. Tonello" Subject: [PATCH v2 2/3] usb: gadget: f_midi: free usb request when done Date: Wed, 23 Sep 2015 13:01:44 +0100 Message-Id: <1443009704-30320-1-git-send-email-eu@felipetonello.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org req->actual == req->length means that there is no data left to enqueue, so free the request. Signed-off-by: Felipe F. Tonello --- Changes in v2: * Re enqueue not fully completed requests, instead of read ALSA buffers. drivers/usb/gadget/function/f_midi.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c index edb84ca..62356cf 100644 --- a/drivers/usb/gadget/function/f_midi.c +++ b/drivers/usb/gadget/function/f_midi.c @@ -256,10 +256,12 @@ f_midi_complete(struct usb_ep *ep, struct usb_request *req) /* We received stuff. req is queued again, below */ f_midi_handle_out_data(ep, req); } else if (ep == midi->in_ep) { - /* Our transmit completed. See if there's more to go. - * f_midi_transmit eats req, don't queue it again. */ - f_midi_transmit(midi, req); - return; + /* Our transmit completed. If there is no more to go, + don't queue it again. */ + if (req->actual == req->length) { + free_ep_req(ep, req); + return; + } } break; -- 2.1.4