From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932382AbbIXBIx (ORCPT ); Wed, 23 Sep 2015 21:08:53 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50429 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932137AbbIXBIv (ORCPT ); Wed, 23 Sep 2015 21:08:51 -0400 From: Sasha Levin To: JBottomley@odin.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Sasha Levin Subject: [PATCH] scsi_dh: avoid allowing dh_state to pass format specs when requesting a module Date: Wed, 23 Sep 2015 21:08:26 -0400 Message-Id: <1443056906-7306-1-git-send-email-sasha.levin@oracle.com> X-Mailer: git-send-email 2.1.4 X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A malicious string passed from userspace might contain format specifiers which request_module() might try to handle, which is bad. Signed-off-by: Sasha Levin --- drivers/scsi/scsi_dh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c index edb044a..24be260 100644 --- a/drivers/scsi/scsi_dh.c +++ b/drivers/scsi/scsi_dh.c @@ -111,7 +111,7 @@ static struct scsi_device_handler *scsi_dh_lookup(const char *name) dh = __scsi_dh_lookup(name); if (!dh) { - request_module(name); + request_module("%s", name); dh = __scsi_dh_lookup(name); } -- 1.7.10.4