From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932496AbbIXCHx (ORCPT ); Wed, 23 Sep 2015 22:07:53 -0400 Received: from ozlabs.org ([103.22.144.67]:46887 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932281AbbIXCHs (ORCPT ); Wed, 23 Sep 2015 22:07:48 -0400 Message-ID: <1443060467.21433.3.camel@ellerman.id.au> Subject: Re: [PATCH] kselftest: using built-in rule when delete file From: Michael Ellerman To: "long.wanglong" Cc: shuahkh@osg.samsung.com, sam.bobroff@au1.ibm.com, aneesh.kumar@linux.vnet.ibm.com, paulus@samba.or, khandual@linux.vnet.ibm.com, gkurz@linux.vnet.ibm.com, anton@samba.org, dvhart@linux.intel.com, tglx@linutronix.de, john.stultz@linaro.org, linux-kernel@vger.kernel.org, wanglong@laoqinren.net, linux-doc@vger.kernel.org, peifeiyue@huawei.com Date: Thu, 24 Sep 2015 12:07:47 +1000 In-Reply-To: <56035A71.9040301@huawei.com> References: <1443001211-119624-1-git-send-email-long.wanglong@huawei.com> <1443059210.21433.1.camel@ellerman.id.au> <56035A71.9040301@huawei.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-09-24 at 10:05 +0800, long.wanglong wrote: > On 2015/9/24 9:46, Michael Ellerman wrote: > > On Wed, 2015-09-23 at 09:40 +0000, Wang Long wrote: > >> Use make's built-in rules to when delete a file > >> or delete files. > > > > It's not a built-in rule, it's a variable. > > Sorry，I did not describe clearly. It is a variable used as > name of program in built-in rules. > > > Personally I think using rm directly is clearer, but I guess this is fine. Do > > you actually want to override $RM ? > > So far, I do not want to override $(RM). But I found that some test's Makefile > using *$(RM)* while the other's using *rm -f*, I think it is better to use one > of them in all unit tests. > > Do you think which one is better? I prefer just using rm -f, because it's less magic, everyone knows what it does. cheers