mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <vinod.koul@intel.com>, <nsekhar@ti.com>, <linux@arm.linux.org.uk>
Cc: <olof@lixom.net>, <arnd@arndb.de>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<dmaengine@vger.kernel.org>
Subject: [PATCH v4 01/25] ARM: common: edma: Fix channel parameter for irq callbacks
Date: Thu, 24 Sep 2015 13:01:48 +0300	[thread overview]
Message-ID: <1443088932-21731-2-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1443088932-21731-1-git-send-email-peter.ujfalusi@ti.com>

In case when the interrupt happened for the second eDMA the channel
number was incorrectly passed to the client driver.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
CC: <stable@vger.kernel.org>
---
 arch/arm/common/edma.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
index 873dbfcc7dc9..56fc339571f9 100644
--- a/arch/arm/common/edma.c
+++ b/arch/arm/common/edma.c
@@ -406,7 +406,8 @@ static irqreturn_t dma_irq_handler(int irq, void *data)
 					BIT(slot));
 			if (edma_cc[ctlr]->intr_data[channel].callback)
 				edma_cc[ctlr]->intr_data[channel].callback(
-					channel, EDMA_DMA_COMPLETE,
+					EDMA_CTLR_CHAN(ctlr, channel),
+					EDMA_DMA_COMPLETE,
 					edma_cc[ctlr]->intr_data[channel].data);
 		}
 	} while (sh_ipr);
@@ -460,7 +461,8 @@ static irqreturn_t dma_ccerr_handler(int irq, void *data)
 					if (edma_cc[ctlr]->intr_data[k].
 								callback) {
 						edma_cc[ctlr]->intr_data[k].
-						callback(k,
+						callback(
+						EDMA_CTLR_CHAN(ctlr, k),
 						EDMA_DMA_CC_ERROR,
 						edma_cc[ctlr]->intr_data
 						[k].data);
-- 
2.5.2


  reply	other threads:[~2015-09-24 10:03 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-24 10:01 [PATCH v4 00/25] dmaengine/ARM: Merge the edma drivers into one Peter Ujfalusi
2015-09-24 10:01 ` Peter Ujfalusi [this message]
2015-09-24 10:01 ` [PATCH v4 02/25] ARM: common: edma: Remove unused functions Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 03/25] dmaengine: edma: Simplify and optimize the edma_execute path Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 04/25] ARM: davinci/common: Convert edma driver to handle one eDMA instance per driver Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 05/25] ARM/dmaengine: edma: Move of_dma_controller_register to the dmaengine driver Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 06/25] ARM: common: edma: Internal API to use pointer to 'struct edma' Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 07/25] ARM/dmaengine: edma: Public API to use private struct pointer Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 08/25] ARM/dmaengine: edma: Remove limitation on the number of eDMA controllers Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 09/25] ARM: davinci: Use platform_device_register_full() to create pdev for eDMA Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 10/25] ARM: davinci: Add dma_mask to eDMA devices Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 11/25] ARM/dmaengine: edma: Merge the two drivers under drivers/dma/ Peter Ujfalusi
2015-10-12 16:00   ` Vinod Koul
2015-10-13  8:58     ` Peter Ujfalusi
2015-10-13 10:39       ` Peter Ujfalusi
2015-09-24 10:01 ` [PATCH v4 12/25] dmaengine: edma: Allocate memory dynamically for bitmaps and structures Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 13/25] dmaengine: edma: Parameter alignment and long line fixes Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 14/25] dmaengine: edma: Use devm_kcalloc when possible Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 15/25] dmaengine: edma: Cleanup regarding the use of dev around the code Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 16/25] dmaengine: edma: Use dev_dbg instead pr_debug Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 17/25] dmaengine: edma: Use the edma_write_slot instead open coded memcpy_toio Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 18/25] dmaengine: edma: Print warning when linking slots from different eDMA Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 19/25] dmaengine: edma: Consolidate the comments for functions Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 20/25] dmaengine: edma: Simplify the interrupt handling Peter Ujfalusi
2015-10-14 10:20   ` Vinod Koul
2015-10-14 11:12     ` Peter Ujfalusi
2015-10-14 11:16       ` Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 21/25] dmaengine: edma: Move the pending error check into helper function Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 22/25] dmaengine: edma: Simplify and optimize ccerr interrupt handler Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 23/25] dmaengine: edma: Read channel mapping support only once from HW Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 24/25] dmaengine: edma: Rename bitfields for slot and channel usage tracking Peter Ujfalusi
2015-09-24 10:02 ` [PATCH v4 25/25] dmaengine: edma: Dynamic paRAM slot handling if HW supports it Peter Ujfalusi
2015-10-06  6:15 ` [PATCH v4 00/25] dmaengine/ARM: Merge the edma drivers into one Peter Ujfalusi
2015-10-06  7:30   ` Koul, Vinod
2015-10-06 10:59     ` Peter Ujfalusi
2015-10-07 10:43 ` Sekhar Nori
2015-10-14 10:27 ` Vinod Koul
2015-10-14 10:50   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443088932-21731-2-git-send-email-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=arnd@arndb.de \
    --cc=dmaengine@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=nsekhar@ti.com \
    --cc=olof@lixom.net \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®