From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757001AbbIXOB5 (ORCPT ); Thu, 24 Sep 2015 10:01:57 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61507 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755974AbbIXOBS (ORCPT ); Thu, 24 Sep 2015 10:01:18 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-79-5604022cf3d2 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Dan Williams , Vinod Koul , dmaengine@vger.kernel.org Subject: [PATCH 09/19] dmaengine: xgene-dma: fix handling xgene_dma_get_ring_size result Date: Thu, 24 Sep 2015 16:00:17 +0200 Message-id: <1443103227-25612-10-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupiluLIzCtJLcpLzFFi42I5/e/4NV0dJpYwg22HjSxurTvHarFxxnpW i+lTLzBarJ76l9Xi8q45bBZrj9xlt3jZt5/Fgd1j8Z6XTB59W1YxenzeJBfAHMVlk5Kak1mW WqRvl8CVsWndStaChdwVp3YuYWxgXMjZxcjBISFgIvH4jlUXIyeQKSZx4d56ti5GLg4hgaWM EtOXNLJCOE1MEv8mLWAEqWIT0JT4u/kmG4gtIqAgsbn3GVgRs8BPRolTp5rYQRLCAlESr2/s AbNZBFQlbj7YBGbzCrhI3GpoZIJYJydx8thkVhCbEyj+duomsLiQgLPEiSOz2CYw8i5gZFjF KJpamlxQnJSea6hXnJhbXJqXrpecn7uJERJCX3YwLj5mdYhRgINRiYfXQYs5TIg1say4MvcQ owQHs5IIL8d7oBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHeubvehwgJpCeWpGanphakFsFkmTg4 pRoY7e/3fHy7P6wyN/tfg/qngIPF7C8vvCqXusivsPohY9Dc5wXnj1ge3n1C31YiWmb9jmnP eZfn/GjYv/mH1OIEbY34DwferGTyer+cqZoxV+CX4mOfkq/l12IyJTc52WWLmV/bJLJh98Q4 3f1pRZu0eBKk7BbYcvTnO/7dy9uusHvd/lL3756PlViKMxINtZiLihMB6sgm5h0CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/dma/xgene-dma.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/dma/xgene-dma.c b/drivers/dma/xgene-dma.c index b23e8d5..c83ae75 100644 --- a/drivers/dma/xgene-dma.c +++ b/drivers/dma/xgene-dma.c @@ -1421,15 +1421,18 @@ static int xgene_dma_create_ring_one(struct xgene_dma_chan *chan, struct xgene_dma_ring *ring, enum xgene_dma_ring_cfgsize cfgsize) { + int ret; + /* Setup DMA ring descriptor variables */ ring->pdma = chan->pdma; ring->cfgsize = cfgsize; ring->num = chan->pdma->ring_num++; ring->id = XGENE_DMA_RING_ID_GET(ring->owner, ring->buf_num); - ring->size = xgene_dma_get_ring_size(chan, cfgsize); - if (ring->size <= 0) - return ring->size; + ret = xgene_dma_get_ring_size(chan, cfgsize); + if (ret <= 0) + return ret; + ring->size = ret; /* Allocate memory for DMA ring descriptor */ ring->desc_vaddr = dma_zalloc_coherent(chan->dev, ring->size, -- 1.9.1