From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757031AbbIXOB7 (ORCPT ); Thu, 24 Sep 2015 10:01:59 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:61507 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755982AbbIXOBT (ORCPT ); Thu, 24 Sep 2015 10:01:19 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-7d-5604022de479 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org Subject: [PATCH 10/19] cx231xx: fix handling cx231xx_read_i2c_data result Date: Thu, 24 Sep 2015 16:00:18 +0200 Message-id: <1443103227-25612-11-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjluLIzCtJLcpLzFFi42I5/e/4NV1dJpYwg8/PLC1urTvHarFxxnpW iyU/dzFZXN41h82iZ8NWVou1R+6yW6x+VuHA7jHl90ZWjy39d9k9+rasYvT4vEkugCWKyyYl NSezLLVI3y6BK+PLaceCpRwVa+cvYm9g/MHWxcjJISFgItG3/TALhC0mceHeeqA4F4eQwFJG if9bPzNBOE1MEl83tjGCVLEJaEr83XwTrFtEQEFic+8zVpAiZoF2JoknEzvBRgkLeEo0dywF s1kEVCUmn58M1swr4CJxb+cCdoh1chInj01mBbE5geJvp25iArGFBJwlThyZxTaBkXcBI8Mq RtHU0uSC4qT0XEO94sTc4tK8dL3k/NxNjJBQ+rKDcfExq0OMAhyMSjy8DlrMYUKsiWXFlbmH GCU4mJVEeDneA4V4UxIrq1KL8uOLSnNSiw8xSnOwKInzzt31PkRIID2xJDU7NbUgtQgmy8TB KdXAqGFm/aooTMckaG6jz98EQcbpbf3x+826+l9dOl5vsiJI/0e5UGL7pZ+iOye/vORsaLVa ypqtLvjDYfaYotzb3OVM1q8cy59OdNBldWAVlfaVskltEe3ckxMiXX4obkHZ34rqv/tVVkhF 9E1k2DCl4I/XyhkfGxNTzvobR205aCwnKSrXK6nEUpyRaKjFXFScCAAkUJlkIQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/media/usb/cx231xx/cx231xx-video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c b/drivers/media/usb/cx231xx/cx231xx-video.c index 9798160..d0d8f08 100644 --- a/drivers/media/usb/cx231xx/cx231xx-video.c +++ b/drivers/media/usb/cx231xx/cx231xx-video.c @@ -1114,7 +1114,8 @@ int cx231xx_enum_input(struct file *file, void *priv, struct cx231xx_fh *fh = priv; struct cx231xx *dev = fh->dev; u32 gen_stat; - unsigned int ret, n; + unsigned int n; + int ret; n = i->index; if (n >= MAX_CX231XX_INPUT) -- 1.9.1