From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932615AbbIXOHW (ORCPT ); Thu, 24 Sep 2015 10:07:22 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:50436 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756041AbbIXOBV (ORCPT ); Thu, 24 Sep 2015 10:01:21 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-84-560402307099 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , MyungJoo Ham , Chanwoo Choi Subject: [PATCH 12/19] extcon: rt8973a: fix handling regmap_irq_get_virq result Date: Thu, 24 Sep 2015 16:00:20 +0200 Message-id: <1443103227-25612-13-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgluLIzCtJLcpLzFFi42I5/e/4NV0DJpYwgw0bWC1urTvHarFxxnpW i+tfnrNaXN41h81i7ZG77Ba3G1ewObB59G1ZxejxeZNcAFMUl01Kak5mWWqRvl0CV8afWztZ C+ZxVLx4N425gfENWxcjJ4eEgInE/EnXWSBsMYkL99YDxbk4hASWMkpsvzubCSQhJNDEJHFs gTKIzSagKfF3802wZhEBBYnNvc9YQRqYBe4zShxe8YMVJCEs4C/R8/Y5O4jNIqAqsb7pD5jN K+AisfTFK2aIbXISJ49NBqvnBIq/nboJapmzxIkjs9gmMPIuYGRYxSiaWppcUJyUnmuoV5yY W1yal66XnJ+7iRESLl92MC4+ZnWIUYCDUYmH10GLOUyINbGsuDL3EKMEB7OSCC/He6AQb0pi ZVVqUX58UWlOavEhRmkOFiVx3rm73ocICaQnlqRmp6YWpBbBZJk4OKUaGL2vhknYtyksuzH3 idCNi4aK9vxqHBILbrGa1dx423N6vcDSzNRdpnev3jeceXbJoaeL1rV2LTW4veSmHOuCMMlu 9XKlc/+3bmmafGSJr6dRh62Ooun/0AnXY1rWxB89dyixhZ9Hv43jVMNXyy61MLW+l+fVjl33 Udl8KEiV/VZFrLyT8s7nK5VYijMSDbWYi4oTAVZkrCITAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/extcon/extcon-rt8973a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/extcon-rt8973a.c index 3428b6a..1bc3737 100644 --- a/drivers/extcon/extcon-rt8973a.c +++ b/drivers/extcon/extcon-rt8973a.c @@ -594,7 +594,7 @@ static int rt8973a_muic_i2c_probe(struct i2c_client *i2c, for (i = 0; i < info->num_muic_irqs; i++) { struct muic_irq *muic_irq = &info->muic_irqs[i]; - unsigned int virq = 0; + int virq = 0; virq = regmap_irq_get_virq(info->irq_data, muic_irq->irq); if (virq <= 0) -- 1.9.1