From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757065AbbIXOCB (ORCPT ); Thu, 24 Sep 2015 10:02:01 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:8846 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755925AbbIXOBW (ORCPT ); Thu, 24 Sep 2015 10:01:22 -0400 X-AuditID: cbfec7f5-f794b6d000001495-ea-560402300bd7 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , MyungJoo Ham , Chanwoo Choi Subject: [PATCH 13/19] extcon: sm5502: fix handling regmap_irq_get_virq result Date: Thu, 24 Sep 2015 16:00:21 +0200 Message-id: <1443103227-25612-14-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgluLIzCtJLcpLzFFi42I5/e/4NV0DJpYwg7Z+G4tb686xWmycsZ7V 4vqX56wWl3fNYbNYe+Quu8XtxhVsDmwefVtWMXp83iQXwBTFZZOSmpNZllqkb5fAlbG7byJj wQyOintrv7I2MD5j62Lk5JAQMJFo693ACmGLSVy4tx4ozsUhJLCUUeLF/nZ2kISQQBOTxLEF yiA2m4CmxN/NN8GaRQQUJDb3PmMFaWAWuM8ocXjFD7BJwgJ+Ekv+/GABsVkEVCX6Ps5hBrF5 BVwk7v54ygyxTU7i5LHJYPWcQPG3UzcxQSxzljhxZBbbBEbeBYwMqxhFU0uTC4qT0nON9IoT c4tL89L1kvNzNzFCwuXrDsalx6wOMQpwMCrx8M7UYQ4TYk0sK67MPcQowcGsJMLL8R4oxJuS WFmVWpQfX1Sak1p8iFGag0VJnHfmrvchQgLpiSWp2ampBalFMFkmDk6pBkYu9mCD6L6XRwPe +qTYLZdfe8h7kueTAxZbMl/Pu/Z7xdyTHa1eCZ+PPpr8b8nb8I/X3+x8MnvespQ9kSqsp6qc Ch/X3kmtc/vYemLrP91X8Qrhks1d39WUf274zS+alsQy0e/39007WKXCF1n3T/GzmDrdvJtz o2vN3yObl+5JFlt75GePh8kOJZbijERDLeai4kQAACnX+BMCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/extcon/extcon-sm5502.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c index 92ae484..2945091 100644 --- a/drivers/extcon/extcon-sm5502.c +++ b/drivers/extcon/extcon-sm5502.c @@ -586,7 +586,7 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c, for (i = 0; i < info->num_muic_irqs; i++) { struct muic_irq *muic_irq = &info->muic_irqs[i]; - unsigned int virq = 0; + int virq = 0; virq = regmap_irq_get_virq(info->irq_data, muic_irq->irq); if (virq <= 0) -- 1.9.1