From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757099AbbIXOCI (ORCPT ); Thu, 24 Sep 2015 10:02:08 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:50445 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756271AbbIXOBa (ORCPT ); Thu, 24 Sep 2015 10:01:30 -0400 X-AuditID: cbfec7f5-f794b6d000001495-0d-56040238fad3 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Realtek linux nic maintainers , netdev@vger.kernel.org Subject: [PATCH 16/19] r8169: fix handling rtl_readphy result Date: Thu, 24 Sep 2015 16:00:24 +0200 Message-id: <1443103227-25612-17-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmluLIzCtJLcpLzFFi42I5/e/4NV0LJpYwg9+T2C1urTvHarFxxnpW i8u75rBZrD1yl93i2AIxiy+9s1gd2Dwev93M7tG3ZRWjx+dNcgHMUVw2Kak5mWWpRfp2CVwZ z+4qFqzjqHi1+hB7A2MzexcjJ4eEgInEzacbWSBsMYkL99azdTFycQgJLGWUOL5+JQuE08Qk MWt+FzNIFZuApsTfzTfZQGwRAQWJzb3PWEGKmAXuMUocnXQZbJSwgK3Es9uXWUFsFgFViVen PgI1cHDwCrhIPP8oDrFNTuLksclgJZxA4bdTNzGB2EICzhInjsxim8DIu4CRYRWjaGppckFx UnqukV5xYm5xaV66XnJ+7iZGSNB83cG49JjVIUYBDkYlHt6ZOsxhQqyJZcWVuYcYJTiYlUR4 Od4DhXhTEiurUovy44tKc1KLDzFKc7AoifPO3PU+REggPbEkNTs1tSC1CCbLxMEp1cDIwNyq V2a8w/vj/CmOLp7sx55s1tpam79BTHHpvGdRqWc82nb8+2T857BeU6RZcnTRV13pv+6Hq3d6 3p8fcaXheeD1osyDNa/e+Vg4dKy5yip24zCr65WLkrGc0xWdpp8S6XV9/F1828vFqlbOpuFx xTo9Vi8WruN4O9NUi6tU5eIk0a2mPg+UWIozEg21mIuKEwFW5+HeFgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/net/ethernet/realtek/r8169.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 2b32e0c..b4f2123 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6081,7 +6081,7 @@ static void rtl_hw_start_8168h_1(struct rtl8169_private *tp) { void __iomem *ioaddr = tp->mmio_addr; struct pci_dev *pdev = tp->pci_dev; - u16 rg_saw_cnt; + int rg_saw_cnt; u32 data; static const struct ephy_info e_info_8168h_1[] = { { 0x1e, 0x0800, 0x0001 }, -- 1.9.1