From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932725AbbIXOCP (ORCPT ); Thu, 24 Sep 2015 10:02:15 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:8858 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756350AbbIXOBd (ORCPT ); Thu, 24 Sep 2015 10:01:33 -0400 X-AuditID: cbfec7f5-f794b6d000001495-18-5604023b0b49 From: Andrzej Hajda To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , Matthew Wilcox , linux-nvme@lists.infradead.org Subject: [PATCH 19/19] block: nvme-scsi: make nvme_trans_get_blk_desc_len return unsigned Date: Thu, 24 Sep 2015 16:00:27 +0200 Message-id: <1443103227-25612-20-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> References: <1443103227-25612-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgluLIzCtJLcpLzFFi42I5/e/4NV1rJpYwg2Ut4ha31p1jtdg4Yz2r xeVdc9gs5i97ym6x9shddouH146yObB5zDsZ6LF5Sb1H35ZVjB6fN8kFsERx2aSk5mSWpRbp 2yVwZXxY08ZS8JCj4uCug4wNjCvZuxg5OSQETCQ2bmxjhbDFJC7cW8/WxcjFISSwlFHizsNu dginiUni36bzzCBVbAKaEn8332QDsUUEFCQ29z5jBSliFrjBKPGg4x5YQlggWuLSvttADRwc LAKqEh/vpIOEeQVcJCbf/80CsU1O4uSxyWCbOYHib6duYgKxhQScJU4cmcU2gZF3ASPDKkbR 1NLkguKk9FwjveLE3OLSvHS95PzcTYyQ8Pm6g3HpMatDjAIcjEo8vDN1mMOEWBPLiitzDzFK cDArifByvAcK8aYkVlalFuXHF5XmpBYfYpTmYFES5525632IkEB6YklqdmpqQWoRTJaJg1Oq gbExYM+Kq6m/RY+9VJeeW1p00ehNxZGSd351KpE5b8O862Qqrsjy8n6Z7rjifsOTR+qvs6Vi 8jMll38yy9lmm3QiwYx9mmTZ5sX5bpP1DdxLrrpmzF1fc7xgReluXfbsmmPXLldN26z/80q4 luyMN2Eec3cKMt97sbnH18dHfFpsyV+nyJwHd5RYijMSDbWYi4oTAQsWraAbAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function returns always non-negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107 Signed-off-by: Andrzej Hajda --- Hi, To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies. Regards Andrzej --- drivers/block/nvme-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nvme-scsi.c b/drivers/block/nvme-scsi.c index e5a63f0..2d65e20 100644 --- a/drivers/block/nvme-scsi.c +++ b/drivers/block/nvme-scsi.c @@ -1091,7 +1091,7 @@ static int nvme_trans_fill_all_pages(struct nvme_ns *ns, struct sg_io_hdr *hdr, MODE_PAGE_INF_EXC_LEN); } -static inline int nvme_trans_get_blk_desc_len(u8 dbd, u8 llbaa) +static inline unsigned int nvme_trans_get_blk_desc_len(u8 dbd, u8 llbaa) { if (dbd == MODE_SENSE_BLK_DESC_ENABLED) { /* SPC-4: len = 8 x Num_of_descriptors if llbaa = 0, 16x if 1 */ -- 1.9.1