From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753943AbbIXUOg (ORCPT ); Thu, 24 Sep 2015 16:14:36 -0400 Received: from mail-bn1bbn0101.outbound.protection.outlook.com ([157.56.111.101]:54594 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753889AbbIXUOc (ORCPT ); Thu, 24 Sep 2015 16:14:32 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=scottwood@freescale.com; Message-ID: <1443125663.32298.32.camel@freescale.com> Subject: Re: [PATCH v2 08/25] powerpc/8xx: Map IMMR area with 512k page at a fixed address From: Scott Wood To: David Laight CC: "'Christophe Leroy'" , Benjamin Herrenschmidt , Paul Mackerras , "Michael Ellerman" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Date: Thu, 24 Sep 2015 15:14:23 -0500 In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CBA15B8@AcuExch.aculab.com> References: <063D6719AE5E284EB5DD2968C1650D6D1CBA15B8@AcuExch.aculab.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.0-fta1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Originating-IP: [2601:448:8100:f9f:a975:1811:5150:7d1a] X-ClientProxiedBy: CY1PR12CA0036.namprd12.prod.outlook.com (25.160.137.46) To BN3PR03MB1478.namprd03.prod.outlook.com (25.163.35.141) X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1478;2:dnfrT9iBzUvAoY3i0N/DZK/fEzj+qycWcEgN3p9bsmb8Hz0ll5YNXEFl2QxAneKH0kIJTmMZ0DyehxiSg3tbeQzoB3X2jlki8fSAderZS1o2AtrktAj4kev25rTSXPvQ+sdavRE3+Pimtj95zWwGfzOkUYxS0su/167xsDpD978=;3:xv+QySsDjN74/A83T1b9lhqKCcyQnhBIBidTzsQHOuFB21RuMhD7h7vhky0nPNJdmXEB9L6kQNer4Ew3K7Fi8Hm1kj/XXjx2YU99O6kwZ6cGDguhL63IMl6aeZ95e3ruj3eIuKnWT/9a3hkjOLbC0w==;25:szO+Hz5SxlXUSyoq+jQqPJ9PBwlbmckifn4dlZWb4vHjc+MY96pMo5JAHIEFbCf1OfoAGF2vc2HgLxAL8h3WQrkXJJjhY/2s48fPPoe3rn490ugTNWN7eSkh0qGKEF0zAcgdmVzfxwXkp7ReZYydlafOoAgYB6BFcDg5oJzFqxR3sDwcHy//jfrx+klqYDoZ9BmWt0oBKwpVypCASu48Kc9RJutzEkZZIxJXj3aPI+l3esCLBWDrssLV7KraXcM/GMsDr02vr4FsxBup2RVJug== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1478; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1478;20:muWJMIclyHKf6TRJgZ9cYAOGQ/fax4lOkPrPq6nCKivj45c2+ST9vtx0oCKQEPUWkPopd0BafSVSw3a8Kuhn6/buHFzuxZlHkDy7LGPYVQ2SuDYzop9Rjm89NUQtZxQgueFHj2JLcCO41k0JI1H8d6KqFQz61yglzp3MD11wFI4XE5F2e0nQDo5BGX2QbKrg11416IXBajIn3InjOESG3uUDvhS6akYiBG2lqx8Zi+/j1/isbiPR2pwB+Q7x5ZI2bwaET1c7V8G/jL4whYZlemsh2BO2rKVTFbyeVyybE2Q/wkKYDB/g4E1Z0JMkp3cZSkXwF1OIHUpdDgVi4BHXK/OQsSNUSBqSJ5g2ACLaAWB/ku9d2WP3Q72qgaC8fB/tFrQwnOcjJpZsaHh8QaTl4zPdhXrDWCjgzDYroW70CjR1/rxntS5HrDOFRP4H6hZXs2TJ5WxJiGxk+P/RTT5azgACBvBegq8AUYgiP68wEta+fiOnCRaMncb/pGXcMc7M;4:n8Mimz8k7WDTSQ06EQA1V+3cVLZwcOtzsO260UZCBgJ4C5xBxkjSTnGNIE/GnntaMTBlCeIAZsUqg+s6yEilpi4/yenO5F7eucl0uWgXu2tIcF0NvKRGhBzNgAYkfanrxmsuQLVP9YCwS1WYYjg3n1H3xdkuQDAb3Sl5rDWHn3axbk0xw+qG/0Qj1ozoVmxsl+iYu86gqVrGNLV/1AERHf1G+6vMQQ98CZ+FYm5QBbCqMCLIUSPL4TB6VqgyWAEKjmSEFrJUnY8ZXBLeYRH7mbzAxeoAeSUwN1mxbG3l14mCe1EbPKDp7xfQfbIvJaufH/w7EL26CS2zB3vO89zGuHY+wJBKXRN2taQKtOsr9DI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(520078)(3002001);SRVR:BN3PR03MB1478;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1478; X-Forefront-PRVS: 070912876F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(199003)(24454002)(189002)(5004730100002)(64706001)(47776003)(5001830100001)(106356001)(40100003)(50466002)(122386002)(5001860100001)(5007970100001)(36756003)(33646002)(97736004)(103116003)(50226001)(62966003)(2950100001)(5820100001)(92566002)(77156002)(76176999)(5001920100001)(23676002)(46102003)(101416001)(68736005)(105586002)(50986999)(86362001)(77096005)(4001540100001)(110136002)(42186005)(81156007)(189998001)(5001960100002)(87976001)(99106002)(3826002)(5001840100002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR03MB1478;H:[IPv6:2601:448:8100:f9f:a975:1811:5150:7d1a];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjAzTUIxNDc4OzIzOk1aVTR2cFEzazlKTUw5Z2ovbTF0QVJGdE56?= =?utf-8?B?OFBVbWlQYjBIQ0pIRnpkdHdkWGJWTXRQZU0rQmNJM3J2NVJCa3AyK1JWcWVl?= =?utf-8?B?SjRDMmJMNGlzMTNlQUk5UVlaS2swWTRSTEtxQlB1N21qNXpUL1h5OUhsZ3ZM?= =?utf-8?B?SDlTWGdsSlVyS0dYY1FYcGgwNmhnTFBVdzk5aVZqNDFOZWdiRWVwL05TSURC?= =?utf-8?B?dEpjU2Jwejk3MGZHN0dmSlk5S3NicTlvNnFya21iMzZadmJKL2Z0aUQ3QllF?= =?utf-8?B?aWZFc3ZIc2pLVGhGN3ViVFNZSFhqeEJwQWpoQnFCTCswWGlENWFRV3QycS9v?= =?utf-8?B?eHZmTVFxRVYyMTBvNkd2Z2ZqYkMvekpzQ0Fyb1RTMENRZE90aVR1L3FpVWpZ?= =?utf-8?B?ejZPZjJkdWJPYVNEeEo2R2lkKzIwZml6Nk1iTVVZeGw2MXJkb3VRellUNTZQ?= =?utf-8?B?ZVRvdmhsVVRMc0JDTE9uQ3dpOFowTEpzQnIwTVpVWXdjK05YN3ptNVgwd2VG?= =?utf-8?B?UEZuNzRXT09DUjNyeElVWXIzYnBQMC9oSDVScXVoZWxvNlJqZ2x5ZFphY2lN?= =?utf-8?B?L3NkUWs4VXFCRXYwTFlXSjhrL3k5bmlEWWpDTFp1a1c0VjlOUHI4clVrUWEv?= =?utf-8?B?REdWbEJKK3pvY1ptZ29oTzlDSGxOMyt5TkdoN1d6V2Z6UTVnTVE5WHJZRDBB?= =?utf-8?B?YkJ0c3BjWnhIK0M1WWxjL0s5V3JzaHNIVUJxYmdMNXhlWFlBcWJUUS80RVpH?= =?utf-8?B?dGYxaEpIYWZ1U1BkWlVLQWJRRTR2TUpwT0JDUHNteTU3TXc0dUlPdVhjc3k1?= =?utf-8?B?emlGK2lMKzZobkhta0RvN0dDWkVWMkZ3YkMwLzNiZE84TFBvMno3eW5abFNw?= =?utf-8?B?SzNmSVhCcFBIVjZSdXYySStha2V0YjNzQ294dHBoREp1Z0I4aEpUU2hJUy9y?= =?utf-8?B?SDk2RVFtWURXU2xMR28xeWlsR0hLZTRYNi8xNHRCaG8vdElPN04vM0pibFM3?= =?utf-8?B?WDA4SXMwSFFUTlpnZ09sUXVSdHU1enpFd3JGNW5pOXNNWHAvYkhXMlJWM1dX?= =?utf-8?B?elZ0Q20wWVpRR1BnZ0V4WHMzK2Vld2lKSkJpdU1FVjJjNzhmeUxweVZ6S3Bw?= =?utf-8?B?QXYrTXFCNlR2MkNWUXF5Q3JCblBWZDlEdmdHZDVMWTZrNE96NjBlYTdoQlR5?= =?utf-8?B?eEVwQy9NazBlWkFCTmVQN0h0d2R6eWVSVkd6eldHZi9NRzkwcXhNQ1o4TFdE?= =?utf-8?B?N1ZNcUl6VUVKamV5NDhFLzB1KzJYNXQ4WHlUdjV2N2VzS01sL0U2a1lqZE9r?= =?utf-8?B?TWpwOWsyQjJVZlFyUGlnZDRjUzBXOFJvNzh5bVRKVlVqNC9hbE9vSnVrRVVV?= =?utf-8?B?L2xSYW9sTWdDdVYydXhhLzNpNUpZQTR3K1dhNExFQnVEYktrWW9RbWpRZVVj?= =?utf-8?B?Q3hZNzZoZFhodkxzWVVCMDEvWU1FNHhjclpvREFpOEV3aGtLbEN0dlpNNTVx?= =?utf-8?B?eGoxVzJnSEpGMGl5NkQwOFFINXZZbGNIU2huU04vWi9xZ0twTVlkRndrOWpL?= =?utf-8?B?N0hzekpCbCtsTnRKem15ZFNQakwyMjRaZDVVV2lkSi9VNm1PNGw2dTMwMXgz?= =?utf-8?B?UXArS1lDYVJ1eWNGdkRNa0RVZ3NCaHpGZ0FzNFRvdjY4OXlGL0NMTDhRPT0=?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1478;5:f6YFoXElUFGdWQI8LBSLxbPMTlNrSjhWsvli0k0XgNg4huvMwFXfJZ8esqFVrH0N2StIJwLF6v7fkTCMan0p9y8vaZhMjb0nEJkuxaCrcOBrAlNiPibGfUMEKDRJh2kqataWuim73/hRyLCjhe4xYw==;24:TF9Xi7Ms9hFHEOfXCdl/Cu2blfblkhDI0yAW7vqDxXK5m/aonE+e1MbjJ1Fk8N1NGDbMHkaALniSgVPN6Tx5xVfNEwrTGeYSBqHByI7U8jY=;20:vxuPobsCTefUCDGihhUYohvjAxo08Ij+c0NzCGFK7/bYKRyrkPFRpIcw/3zMValhmGGzfHbLuLEUFkA2NkhQhw== SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Sep 2015 20:14:29.7972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1478 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-09-24 at 11:41 +0000, David Laight wrote: > From: Christophe Leroy > > Sent: 22 September 2015 17:51 > ... > > Traditionaly, each driver manages one computer board which has its > > own components with its own memory maps. > > But on embedded chips like the MPC8xx, the SOC has all registers > > located in the same IO area. > > > > When looking at ioremaps done during startup, we see that > > many drivers are re-mapping small parts of the IMMR for their own use > > and all those small pieces gets their own 4k page, amplifying the > > number of TLB misses: in our system we get 0xff000000 mapped 31 times > > and 0xff003000 mapped 9 times. > > Isn't this a more general problem? > > If there are multiple remap requests for the same physical page > shouldn't the kernel be just increasing a reference count somewhere > and returning address in the same virtual page? > This should probably happen regardless of the address. > I presume it must be done for cacheable mappings. Why would you assume that? -Scott