From: Andrzej Hajda <a.hajda@samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH v2 18/19] mac80211: make ieee80211_new_mesh_header return unsigned
Date: Fri, 25 Sep 2015 08:42:00 +0200 [thread overview]
Message-ID: <1443163320-25593-1-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <1443103799.1869.6.camel@sipsolutions.net>
The function returns always non-negative values.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
v2: added missing declaration change, fixed indentation
---
net/mac80211/mesh.c | 6 +++---
net/mac80211/mesh.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c
index e06a5ca..90567fc 100644
--- a/net/mac80211/mesh.c
+++ b/net/mac80211/mesh.c
@@ -540,9 +540,9 @@ int ieee80211_fill_mesh_addresses(struct ieee80211_hdr *hdr, __le16 *fc,
*
* Return the header length.
*/
-int ieee80211_new_mesh_header(struct ieee80211_sub_if_data *sdata,
- struct ieee80211s_hdr *meshhdr,
- const char *addr4or5, const char *addr6)
+unsigned int ieee80211_new_mesh_header(struct ieee80211_sub_if_data *sdata,
+ struct ieee80211s_hdr *meshhdr,
+ const char *addr4or5, const char *addr6)
{
if (WARN_ON(!addr4or5 && addr6))
return 0;
diff --git a/net/mac80211/mesh.h b/net/mac80211/mesh.h
index 50c8473..029e41d 100644
--- a/net/mac80211/mesh.h
+++ b/net/mac80211/mesh.h
@@ -207,9 +207,9 @@ struct mesh_rmc {
/* Various */
int ieee80211_fill_mesh_addresses(struct ieee80211_hdr *hdr, __le16 *fc,
const u8 *da, const u8 *sa);
-int ieee80211_new_mesh_header(struct ieee80211_sub_if_data *sdata,
- struct ieee80211s_hdr *meshhdr,
- const char *addr4or5, const char *addr6);
+unsigned int ieee80211_new_mesh_header(struct ieee80211_sub_if_data *sdata,
+ struct ieee80211s_hdr *meshhdr,
+ const char *addr4or5, const char *addr6);
int mesh_rmc_check(struct ieee80211_sub_if_data *sdata,
const u8 *addr, struct ieee80211s_hdr *mesh_hdr);
bool mesh_matches_local(struct ieee80211_sub_if_data *sdata,
--
1.9.1
next prev parent reply other threads:[~2015-09-25 6:42 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 14:00 [PATCH 00/19] Fixes related to incorrect assignment of signed results function Andrzej Hajda
2015-09-24 14:00 ` [PATCH 01/19] SUNRPC: fix variable type Andrzej Hajda
2015-09-25 20:25 ` J. Bruce Fields
2015-09-24 14:00 ` [PATCH 02/19] spi: davinci: fix handling platform_get_irq result Andrzej Hajda
2015-09-24 14:00 ` [PATCH 03/19] libata: samsung_cf: " Andrzej Hajda
2015-09-24 14:53 ` Tejun Heo
2015-09-25 6:43 ` [PATCH v2 " Andrzej Hajda
2015-09-25 15:50 ` Tejun Heo
2015-09-24 14:00 ` [PATCH 04/19] v4l: omap3isp: " Andrzej Hajda
2015-11-09 20:16 ` Laurent Pinchart
2015-11-10 6:48 ` Andrzej Hajda
2015-11-10 8:53 ` Laurent Pinchart
2015-11-10 9:59 ` Andrzej Hajda
2015-09-24 14:00 ` [PATCH 05/19] media: am437x-vpfe: " Andrzej Hajda
2015-09-24 14:00 ` [PATCH 06/19] staging: media: omap4iss: " Andrzej Hajda
2015-09-24 15:07 ` Dan Carpenter
2015-09-24 14:00 ` [PATCH 07/19] net: hisilicon: " Andrzej Hajda
2015-09-27 5:47 ` David Miller
2015-09-24 14:00 ` [PATCH 08/19] clk: st: fix handling result of of_property_count_strings Andrzej Hajda
2015-10-01 22:23 ` Stephen Boyd
2015-09-24 14:00 ` [PATCH 09/19] dmaengine: xgene-dma: fix handling xgene_dma_get_ring_size result Andrzej Hajda
2015-09-25 2:09 ` Vinod Koul
2015-09-24 14:00 ` [PATCH 10/19] cx231xx: fix handling cx231xx_read_i2c_data result Andrzej Hajda
2015-09-24 14:00 ` [PATCH 11/19] clocksource: fix __ftm_clk_init result Andrzej Hajda
2015-12-14 10:34 ` Andrzej Hajda
2015-12-14 13:27 ` Daniel Lezcano
2015-09-24 14:00 ` [PATCH 12/19] extcon: rt8973a: fix handling regmap_irq_get_virq result Andrzej Hajda
2015-09-24 23:40 ` Chanwoo Choi
2015-09-24 14:00 ` [PATCH 13/19] extcon: sm5502: " Andrzej Hajda
2015-09-24 23:40 ` Chanwoo Choi
2015-09-24 14:00 ` [PATCH 14/19] sony-laptop: fix handling sony_nc_hotkeys_decode result Andrzej Hajda
2015-10-03 16:39 ` Darren Hart
2015-10-05 7:42 ` Andrzej Hajda
2015-09-24 14:00 ` [PATCH 15/19] KVM: PPC: e500: fix handling local_sid_lookup result Andrzej Hajda
2015-09-24 22:58 ` Scott Wood
2015-10-15 5:30 ` Paul Mackerras
2015-09-24 14:00 ` [PATCH 16/19] r8169: fix handling rtl_readphy result Andrzej Hajda
2015-09-27 5:48 ` David Miller
2015-09-24 14:00 ` [PATCH 17/19] tools: bpf_jit_disasm: make get_last_jit_image return unsigned Andrzej Hajda
2015-09-24 18:53 ` Daniel Borkmann
2015-09-25 6:45 ` [PATCH v2 " Andrzej Hajda
2015-09-29 5:18 ` David Miller
2015-09-24 14:00 ` [PATCH 18/19] mac80211: make ieee80211_new_mesh_header " Andrzej Hajda
2015-09-24 14:09 ` Johannes Berg
2015-09-25 6:42 ` Andrzej Hajda [this message]
2015-09-24 14:00 ` [PATCH 19/19] block: nvme-scsi: make nvme_trans_get_blk_desc_len " Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443163320-25593-1-git-send-email-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®